Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passenv declaration in tox.ini #1280

Merged

Conversation

rafaelweingartner
Copy link
Contributor

@rafaelweingartner rafaelweingartner commented Jan 6, 2023

While running the tests locally with the latest tox I was getting the following error message:

pep8: failed with pass_env values cannot contain whitespace, use comma to have multiple values in a single line, invalid values found 'LANG GNOCCHI_TEST_* AWS_*'
  pep8: FAIL code 1 (0.00 seconds)
  evaluation failed :( (0.09 seconds)

That error is happening because of the passenv declaration. This patch is proposing a fix for that.

@rafaelweingartner
Copy link
Contributor Author

This PR is also going to depend on #1279

@tobias-urdin
Copy link
Contributor

@Mergifyio rebase

While running the tests locally with the latest tox I was getting the following error message:
```
pep8: failed with pass_env values cannot contain whitespace, use comma to have multiple values in a single line, invalid values found 'LANG GNOCCHI_TEST_* AWS_*'
  pep8: FAIL code 1 (0.00 seconds)
  evaluation failed :( (0.09 seconds)

```

That error is happening because of the passenv declaration. This patch is proposing a fix for that.
@mergify
Copy link
Contributor

mergify bot commented Jan 20, 2023

⚠️ This pull request got rebased on behalf of a random user of the organization.
This behavior will change on the 1st February 2023, Mergify will pick the author of the pull request instead.

To get the future behavior now, you can configure bot_account options (e.g.: bot_account: { author } or update_bot_account: { author }.

Or you can create a dedicated github account for squash and rebase operations, and use it in different bot_account options.

@mergify
Copy link
Contributor

mergify bot commented Jan 20, 2023

rebase

✅ Branch has been successfully rebased

@chungg chungg force-pushed the fix_pass_env_declaration branch from d10fabf to 83db4d6 Compare January 20, 2023 00:28
@tobias-urdin tobias-urdin merged commit dcff4ff into gnocchixyz:master Jan 20, 2023
@tobias-urdin
Copy link
Contributor

@Mergifyio backport stable/4.4

@mergify
Copy link
Contributor

mergify bot commented Jan 20, 2023

backport stable/4.4

✅ Backports have been created

tobias-urdin added a commit that referenced this pull request Jan 20, 2023
Fix `passenv` declaration in tox.ini (backport #1280)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants