Fix README include bound #1167
Merged
Fix README include bound #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a specific string as the magic marker
jd
approved these changes
Jul 17, 2021
chungg
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a specific string as the magic marker. Repeated as an actual string (on line 5) because '...-after' is actually after that line, not that line and later. Can't seem to use a comment/crossref marker like
.. _doc_include_marker:andstart-afterthat. If the intro README line changes, then the docs build will break, rather than strangely truncating.If you want to just keep the
start-lineoption, it's now 9.