ci: add separate winget release workflow #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It errors because the workflow has an option to publish as draft, which then causes the winget release step to not find it :(
Regex and version identifiers should actually be working fine. Think the best solution here would be to move out the winget release to a separate workflow triggered on release, e.g. name: Winget publish
on:
release:
types: [published] |
|
Oh yep you are right I didn't notice that, let me do it |
vikingnope
changed the title
lars-berger
reviewed
Sep 29, 2024
|
Ay sweet, thanks for taking care of this. Just some small style changes otherwise lgtm |
lars-berger
reviewed
Sep 29, 2024
lars-berger
changed the title
|
Thank you 🙌 |
|
If you try to run it right now it won't work as I already opened a PR for it |
|
Absolute chad |
|
🎉 This PR is included in version 3.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed winget workflow to correctly run as intended during publish of new release