Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: be able to change tiling direction when moving window via mouse #673

Merged
merged 12 commits into from
Aug 15, 2024

Conversation

LucaCoduriV
Copy link
Contributor

@LucaCoduriV LucaCoduriV commented Aug 12, 2024

closes #564

Description

This pull request addresses two bugs related to window management within containers and one enhancement:

  1. Bug 1: Incomplete Window Reorganization

    • Issue: When a window is inside a container, dragging the window sometimes leaves gaps in the tiling arrangement.
    • Discovery: This issue occurs because the container was not being added to the pending sync vector.
    • Solution: Add the container to the pending sync vector to ensure proper reorganization of windows.
  2. Bug 2: Workspace Crash with Split Containers

    • Issue: When at least three windows are in a split container, moving a window (highlighted with a red arrow in the screenshot) into the child split causes an error stating that the parent has no workspace, leading to a crash.
    • Discovery: The crash happens when attempting to move the window into the workspace before setting it as a floating window.
    • Solution: Fix the issue by ensuring the dragged window is moved into the workspace before it is set as a floating window.
      image
  3. Enhancement: Improved Window Splitting Options

    • Feature: Previously, window splitting was limited in direction. This enhancement allows users to split windows in all four directions: top, bottom, left, and right.
    • Benefit: Provides greater flexibility in window management, allowing for more customized layouts based on user preferences.

@lars-berger
Copy link
Member

lars-berger commented Aug 14, 2024

Closes #619 #641

@lars-berger lars-berger changed the title Fix: Mouse drag feat: be able to change tiling direction when moving window via mouse Aug 15, 2024
@lars-berger lars-berger merged commit 396182c into glzr-io:main Aug 15, 2024
1 of 2 checks passed
Copy link

🎉 This PR is included in version 3.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Move windows with mouse
2 participants