-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Soundness issues in autogenerated code #26
Comments
bors bot
pushed a commit
to bevyengine/bevy
that referenced
this issue
Jul 16, 2022
# Objective - 0.8 is coming soon, and our mikktspace implementation is unsound - see gltf-rs/mikktspace#26 - Best not to ship that ## Solution - Fix the unsoundness in a minimal way - Obviously there might be others, but it seems unlikely we have any way to know about those
bors bot
pushed a commit
to bevyengine/bevy
that referenced
this issue
Jul 16, 2022
# Objective - 0.8 is coming soon, and our mikktspace implementation is unsound - see gltf-rs/mikktspace#26 - Best not to ship that ## Solution - Fix the unsoundness in a minimal way - Obviously there might be others, but it seems unlikely we have any way to know about those
bors bot
pushed a commit
to bevyengine/bevy
that referenced
this issue
Jul 16, 2022
# Objective - 0.8 is coming soon, and our mikktspace implementation is unsound - see gltf-rs/mikktspace#26 - Best not to ship that ## Solution - Fix the unsoundness in a minimal way - Obviously there might be others, but it seems unlikely we have any way to know about those
inodentry
pushed a commit
to IyesGames/bevy
that referenced
this issue
Aug 8, 2022
# Objective - 0.8 is coming soon, and our mikktspace implementation is unsound - see gltf-rs/mikktspace#26 - Best not to ship that ## Solution - Fix the unsoundness in a minimal way - Obviously there might be others, but it seems unlikely we have any way to know about those
james7132
pushed a commit
to james7132/bevy
that referenced
this issue
Oct 28, 2022
# Objective - 0.8 is coming soon, and our mikktspace implementation is unsound - see gltf-rs/mikktspace#26 - Best not to ship that ## Solution - Fix the unsoundness in a minimal way - Obviously there might be others, but it seems unlikely we have any way to know about those
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this issue
Feb 1, 2023
# Objective - 0.8 is coming soon, and our mikktspace implementation is unsound - see gltf-rs/mikktspace#26 - Best not to ship that ## Solution - Fix the unsoundness in a minimal way - Obviously there might be others, but it seems unlikely we have any way to know about those
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The following snippet extracted from this crate failed under MIRI:
This was noticed as part of bevyengine/bevy#4932, an effort to rewrite this crate into idiomatic Rust. There may be other soundness issues; the autogenerated code uses a lot of pointless unsafe in strange ways.
The text was updated successfully, but these errors were encountered: