Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer] Make workspace garbage collection configurable #9862

Merged
merged 2 commits into from
May 10, 2022

Conversation

andrew-farries
Copy link
Contributor

Description

One of the Webapp team's epics for Q2 is to use the Gitpod installer to deploy to Gitpod SaaS. In order to do that we will need to add additional configuration to the installer to make the output suitable for a SaaS deployment as opposed to a self-hosted deployment.

This PR makes workspace garbage collection configurable by adding a new experimental.webapp.server.disableWorkspaceGarbageCollection flag to the installer config.

Related Issue(s)

Part of #9097

How to test

Create an installer config file containing this experimental section:

experimental:
  webapp:
    server:
      disableWorkspaceGarbageCollection: true

Get a versions.yaml for use with the installer:

docker run -it --rm "eu.gcr.io/gitpod-core-dev/build/versions:${version}" cat versions.yaml > versions.yaml

Then invoke the installer as:

go run . render --debug-version-file versions.yaml --config /path/to/config --use-experimental-config

The workspaceGarbageCollection.disabled field in the server config map will reflect the value set in the installer config.

Release Notes

Add `disableWorkspaceGarbageCollection` experimental installer config flag

Documentation

None.

Andrew Farries added 2 commits May 9, 2022 10:34
@andrew-farries andrew-farries requested review from a team May 9, 2022 10:48
@github-actions github-actions bot added team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team labels May 9, 2022
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@Pothulapati Pothulapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@roboquat roboquat merged commit 57ce815 into main May 10, 2022
@roboquat roboquat deleted the ad/installer-workspace-garbage-collection branch May 10, 2022 07:08
@roboquat roboquat added the deployed: webapp Meta team change is running in production label May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production release-note size/S team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants