try to fix tracing #9625
Closed
try to fix tracing #9625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/werft run 👍 started the job as gitpod-build-at-mess-with-tracing.1 |
AlexTugarev
commented
May 24, 2022
| @@ -28,7 +28,8 @@ export namespace TraceContext { | |||
| if (!!parentCtx?.span) { | |||
| const ctx = parentCtx?.span?.context(); | |||
| if (ctx && !!ctx.toTraceId() && !!ctx.toSpanId()) { | |||
| options.references = [opentracing.followsFrom(ctx)]; | |||
| // options.references = [opentracing.followsFrom(ctx)]; | |||
| options.childOf = ctx; | |||
There was a problem hiding this comment.
@geropl, is this still an issue?
There was a problem hiding this comment.
No, I think we should leave it as-is. The problems we faced were mostly solved by Mad's attempts to find dangling spans that were not finish()ed. 👍
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
meta: stale
|
Closing, because I'm out of ideas on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up to #9281