Fix auth providers #9046
Merged
Fix auth providers #9046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexTugarev
force-pushed
the
at/zzz-auth
branch
from
e8020f4 to
5f26bb2
Compare
|
/hold ... until 9ee97f3 is removed. |
geropl
reviewed
Mar 31, 2022
geropl
reviewed
Mar 31, 2022
geropl
reviewed
Mar 31, 2022
|
Looks good in general, please have a look at the comments for small fixes. Please ping again for ✔️ |
geropl
reviewed
Mar 31, 2022
geropl
reviewed
Mar 31, 2022
this primarily affects self-hosted installation where the `ownerId` is about to change during the initial setup of the login/git provider.
AlexTugarev
force-pushed
the
at/zzz-auth
branch
from
5f26bb2 to
c376354
Compare
|
Have checked and this works perfectly 👍🏻 |
mrsimonemms
approved these changes
Mar 31, 2022
|
/unhold |
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unblocks setups of self-hosted installations, where login providers didn't show up after creation, i.e. login was not possible at all afterwards.
This regression was introduces in #8431 by limiting auth-provider updates to changes identified by comparing a sha of contents, but the content did not include verification status nor the ownerId property, which led to a stale state.
Fixes #8927