-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KOTS]: extract images from the Installer and put in the additionalImages array #8962
Conversation
8ffeb85
to
c48e086
Compare
The additional images are a way of telling Replicated which images are required to make an air-gapped installation
The `additionalImages` are used by KOTS to pull in any images used that are not defined in a manifest. These are then processed by KOTS and used to make the air-gapped bundle
c48e086
to
1b00c0e
Compare
additionalImages
array
additionalImages
arrayThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and works as expected!
Unrealted question, For most images we are restricted on a specific commit, except for some IDE images for which we also have latest
. wondering, why? 🤔
That's a question for @akosyakov and the @gitpod-io/engineering-ide team I think, but my understanding is so that the IDEs get updated whenever the owners push a change. As it's a third-party product, we're not directly involved in the release cycle so don't want to couple it to our releases. |
Stable versions are manually released and pinned to ensure compatibility with current version of Gitpod. Latest versions (VS Code Insiders, JB EAP) are released on nightly basis to test new changes. Latest versions does not guarantee stability and may occasionally break. |
Description
For airgapped mode to work, we need to specify the images used if they are not directly specified in the manifests - the Installer image will be the only one included automatically. As we're using the Installer to manage the container images, we must add these to the
additionalImages
spec.As we already have the
mirror list
command, this creates amirror kots
command to add theadditionalImages
into thekots-app.yaml
file. This uses the same underlying command as themirror list
command, but reworks it so theoriginal
image is added in - KOTS will then process these images and include them in the internal registry when an airgapped installation is requested.See KOTS docs
Related Issue(s)
Fixes #9042
How to test
Manually trigger an airgap build for this branch and ensure that it complete successfully.
Uploaded
kots-app.yaml
- see release:Success message - see build:
Release Notes
Documentation