Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KOTS]: extract images from the Installer and put in the additionalImages array #8962

Merged
merged 3 commits into from
Apr 1, 2022

Conversation

mrsimonemms
Copy link
Contributor

@mrsimonemms mrsimonemms commented Mar 26, 2022

Description

For airgapped mode to work, we need to specify the images used if they are not directly specified in the manifests - the Installer image will be the only one included automatically. As we're using the Installer to manage the container images, we must add these to the additionalImages spec.

As we already have the mirror list command, this creates a mirror kots command to add the additionalImages into the kots-app.yaml file. This uses the same underlying command as the mirror list command, but reworks it so the original image is added in - KOTS will then process these images and include them in the internal registry when an airgapped installation is requested.

See KOTS docs

Related Issue(s)

Fixes #9042

How to test

Manually trigger an airgap build for this branch and ensure that it complete successfully.

Uploaded kots-app.yaml - see release:

image

Success message - see build:

image

Release Notes

[KOTS]: extract images from the Installer and put in the additionalImages array

Documentation

Simon Emms added 3 commits March 31, 2022 08:32
The additional images are a way of telling Replicated which images are
required to make an air-gapped installation
The `additionalImages` are used by KOTS to pull in any images used that
are not defined in a manifest. These are then processed by KOTS and used
to make the air-gapped bundle
@mrsimonemms mrsimonemms changed the title WIP: [KOTS]: enable kots to work in airgapped mode [KOTS]: enable KOTS to work in airgapped mode Mar 31, 2022
@mrsimonemms mrsimonemms changed the title [KOTS]: enable KOTS to work in airgapped mode [KOTS]: extract images from the Installer and put in the additionalImages array Mar 31, 2022
@mrsimonemms mrsimonemms changed the title [KOTS]: extract images from the Installer and put in the additionalImages array [KOTS]: extract images from the Installer and put in the additionalImages array Mar 31, 2022
@mrsimonemms mrsimonemms changed the title [KOTS]: extract images from the Installer and put in the additionalImages array [KOTS]: extract images from the Installer and put in the additionalImages array Mar 31, 2022
@mrsimonemms mrsimonemms marked this pull request as ready for review March 31, 2022 09:37
@mrsimonemms mrsimonemms requested a review from a team March 31, 2022 09:37
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Mar 31, 2022
Copy link
Contributor

@Pothulapati Pothulapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and works as expected!

Unrealted question, For most images we are restricted on a specific commit, except for some IDE images for which we also have latest. wondering, why? 🤔

@roboquat roboquat merged commit 47b17f7 into main Apr 1, 2022
@roboquat roboquat deleted the sje/kots-airgap branch April 1, 2022 08:15
@mrsimonemms
Copy link
Contributor Author

That's a question for @akosyakov and the @gitpod-io/engineering-ide team I think, but my understanding is so that the IDEs get updated whenever the owners push a change. As it's a third-party product, we're not directly involved in the release cycle so don't want to couple it to our releases.

@akosyakov
Copy link
Member

akosyakov commented Apr 1, 2022

Unrealted question, For most images we are restricted on a specific commit, except for some IDE images for which we also have latest. wondering, why?

Stable versions are manually released and pinned to ensure compatibility with current version of Gitpod. Latest versions (VS Code Insiders, JB EAP) are released on nightly basis to test new changes. Latest versions does not guarantee stability and may occasionally break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/XXL team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extract images from the Installer and put in the additionalImages array
4 participants