Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update team deletion confirmation modal #8772

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Conversation

gtsiolis
Copy link
Contributor

Description

Update team deletion modal to reflect changes in the product.

How to test

  1. Create a team
  2. Try to delete a team
  3. Check the confirmation modal is accurate

Release Notes

Update team deletion confirmation modal

@gtsiolis gtsiolis requested a review from a team March 11, 2022 21:40
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Mar 11, 2022
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #8772 (69e973e) into main (55b3ec2) will not change coverage.
The diff coverage is n/a.

❗ Current head 69e973e differs from pull request most recent head e5e4d67. Consider uploading reports for the commit e5e4d67 to get more accurate results

@@           Coverage Diff           @@
##             main    #8772   +/-   ##
=======================================
  Coverage   11.17%   11.17%           
=======================================
  Files          18       18           
  Lines         993      993           
=======================================
  Hits          111      111           
  Misses        880      880           
  Partials        2        2           
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@stale
Copy link

stale bot commented Mar 22, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Mar 22, 2022
@gtsiolis gtsiolis added meta: never-stale This issue can never become stale and removed meta: stale This issue/PR is stale and will be closed soon labels Mar 22, 2022
easyCZ
easyCZ previously approved these changes Mar 28, 2022
Copy link
Member

@easyCZ easyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but will need a rebase.

@gtsiolis gtsiolis force-pushed the gt/update-team-deletion-modal branch from 69e973e to e5e4d67 Compare March 28, 2022 10:34
@roboquat roboquat added size/XS and removed size/M labels Mar 28, 2022
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Mar 28, 2022

Thanks for taking a look, @easyCZ!

Rebased, waiting for build to finish, and will merge afterwards. 🏓

@gtsiolis gtsiolis requested a review from easyCZ March 28, 2022 11:48
@gtsiolis
Copy link
Contributor Author

@easyCZ could you approve again to unblock merging this?

@roboquat roboquat merged commit 7abdeab into main Mar 28, 2022
@roboquat roboquat deleted the gt/update-team-deletion-modal branch March 28, 2022 12:15
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Mar 28, 2022

Díky, @easyCZ! 🍻

@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production meta: never-stale This issue can never become stale release-note size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants