Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer] Add missing kube-rbac-proxy container in ws-manager deployment #7769

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jan 22, 2022

Fixes #7766

How to test

Initialize and render the manifests created by the installer CLI and verify the kube-rbac-proxy container is present in ws-manager deployment

Release Notes

[installer] Add missing kube-rbac-proxy container in ws-manager deployment

@aledbf aledbf requested a review from csweichel January 22, 2022 12:11
@roboquat roboquat added team: workspace Issue belongs to the Workspace team size/XS labels Jan 22, 2022
@codecov
Copy link

codecov bot commented Jan 22, 2022

Codecov Report

Merging #7769 (1405f69) into main (71f5431) will decrease coverage by 3.70%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main   #7769      +/-   ##
=========================================
- Coverage   11.54%   7.84%   -3.71%     
=========================================
  Files          20      31      +11     
  Lines        1169    2168     +999     
=========================================
+ Hits          135     170      +35     
- Misses       1031    1996     +965     
+ Partials        3       2       -1     
Flag Coverage Δ
components-gitpod-cli-app 10.28% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
installer-raw-app 5.74% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
installer/pkg/components/ws-manager/deployment.go 0.00% <0.00%> (ø)
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go
installer/pkg/components/ws-manager/tlssecret.go 0.00% <0.00%> (ø)
installer/pkg/common/objects.go 0.00% <0.00%> (ø)
...staller/pkg/components/ws-manager/networkpolicy.go 0.00% <0.00%> (ø)
installer/pkg/common/display.go 0.00% <0.00%> (ø)
installer/pkg/common/storage.go 0.00% <0.00%> (ø)
installer/pkg/common/render.go 0.00% <0.00%> (ø)
installer/pkg/components/ws-manager/role.go 0.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71f5431...1405f69. Read the comment docs.

@mrsimonemms
Copy link
Contributor

/lgtm
/approve

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: bfd3e4884930bb26e6c26cd41b8b9d5eaa880ccb

@aledbf
Copy link
Member Author

aledbf commented Jan 25, 2022

/approve

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, MrSimonEmms

Associated issue: #7766

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit fc3e829 into main Jan 25, 2022
@roboquat roboquat deleted the aledbf/prom branch January 25, 2022 15:52
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/XS team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[installer] ws-manager is rendered without kube-rbac-proxy
3 participants