Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] Don't offer to add common email domains as a verified student domains in Admin #7659

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

jankeromnes
Copy link
Contributor

Description

Follow-up to #7637 -- don't show a link (that silently fails) when the email domain is gmail.com, yahoo.com or hotmail.com (the 3 most common email domains).

Related Issue(s)

None

How to test

Release Notes

[dashboard] Don't offer to add common email domains as a verified student domains in Admin

Documentation

/uncc

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

No associated issue. Requirement bypassed by manually added approval.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

No associated issue. Requirement bypassed by manually added approval.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat added team: webapp Issue belongs to the WebApp team size/XS labels Jan 18, 2022
@laushinka
Copy link
Contributor

Code looks good! Can't test the preview yet since the build failed due to what looks like installer errors? Happy to give my thumbs up though since it's obvious what it will do.

@jankeromnes
Copy link
Contributor Author

jankeromnes commented Jan 18, 2022

Many thanks again @laushinka ! 🙏

Rerolling Werft 🎲 😁

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-jx-better-gmail-fix.1

@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #7659 (ab73785) into main (c9e8709) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7659   +/-   ##
=======================================
  Coverage   10.38%   10.38%           
=======================================
  Files          18       18           
  Lines         992      992           
=======================================
  Hits          103      103           
  Misses        888      888           
  Partials        1        1           
Flag Coverage Δ
components-gitpod-cli-app 10.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 720b24b...ab73785. Read the comment docs.

@laushinka
Copy link
Contributor

Tested!
LGTM

@jankeromnes
Copy link
Contributor Author

jankeromnes commented Jan 18, 2022

Thank you so much 🙏

@roboquat roboquat merged commit b5728fc into main Jan 18, 2022
@roboquat roboquat deleted the jx/better-gmail-fix branch January 18, 2022 14:25
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants