-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dashboard] Don't offer to add common email domains as a verified student domains in Admin #7659
Conversation
…dent domains in Admin
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: No associated issue. Requirement bypassed by manually added approval. The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: No associated issue. Requirement bypassed by manually added approval. The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Code looks good! Can't test the preview yet since the build failed due to what looks like installer errors? Happy to give my thumbs up though since it's obvious what it will do. |
Many thanks again @laushinka ! 🙏 Rerolling Werft 🎲 😁 /werft run with-clean-slate-deployment 👍 started the job as gitpod-build-jx-better-gmail-fix.1 |
Codecov Report
@@ Coverage Diff @@
## main #7659 +/- ##
=======================================
Coverage 10.38% 10.38%
=======================================
Files 18 18
Lines 992 992
=======================================
Hits 103 103
Misses 888 888
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Tested! |
Thank you so much 🙏 |
Description
Follow-up to #7637 -- don't show a link (that silently fails) when the email domain is
gmail.com
,yahoo.com
orhotmail.com
(the 3 most common email domains).Related Issue(s)
None
How to test
Release Notes
Documentation
/uncc