-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[installer] Add option to use S3 as docker-registry backend #6912
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6912 +/- ##
==========================================
- Coverage 19.04% 5.83% -13.22%
==========================================
Files 2 13 +11
Lines 168 1148 +980
==========================================
+ Hits 32 67 +35
- Misses 134 1080 +946
+ Partials 2 1 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/lgtm I've put it on hold in case @csweichel wants to vary this approach, but it looks good to me |
LGTM label has been added. Git tree hash: a295ae24be35ccf9a89f4e3c9b002e20a4d94a13
|
/approve no-issue |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrSimonEmms Associated issue requirement bypassed by: MrSimonEmms The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The feature makes sense to me. I'm just weary of the cost it incurs, i.e. yet another test case. /hold cancel |
/hold cancel |
Description
Enable S3 as backend storage for
inCluster
docker-registry
.This is useful in at least two scenarios:
Release Notes