-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve team scope in dashboard #6577
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6577 +/- ##
========================================
- Coverage 8.18% 6.43% -1.76%
========================================
Files 14 12 -2
Lines 1209 1041 -168
========================================
- Hits 99 67 -32
+ Misses 1107 973 -134
+ Partials 3 1 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@laushinka could you take a look at this small change when you're free? 🏓 Should be ok to merge but I could be missing any edge case(s) as |
Works as expected! And yes, "/" to "projects" already handled in the top-level routing. /lgtm |
LGTM label has been added. Git tree hash: 932005f9da25c74e404189a6b80263d2a01a872d
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: laushinka Associated issue: #6575 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Terima kasih, @laushinka! 🏀 |
Aww, sama-sama 🥰 |
Description
This will change the default dashboard URL from
/projects
to/
as we already handle this redirect when needed and redirect back to the last selected team. See also relevant comment in #6048 (comment).Risk
Worth checking what happens after deleting a team.
Related Issue(s)
An attempt to fix #6575.
How to test
Release Notes