Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve team scope in dashboard #6577

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Nov 5, 2021

Description

This will change the default dashboard URL from /projects to / as we already handle this redirect when needed and redirect back to the last selected team. See also relevant comment in #6048 (comment).

Risk

Worth checking what happens after deleting a team.

Related Issue(s)

An attempt to fix #6575.

How to test

  1. Create a team
  2. Add a project
  3. Start a workspace for the added project
  4. Stop the workspace
  5. Click on the Go to Dashboard button
  6. Land in projects within the newly created team instead of projects within the personal account

Release Notes

Preserve team scope in dashboard

@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #6577 (8717c84) into main (9358ca9) will decrease coverage by 1.75%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##            main   #6577      +/-   ##
========================================
- Coverage   8.18%   6.43%   -1.76%     
========================================
  Files         14      12       -2     
  Lines       1209    1041     -168     
========================================
- Hits          99      67      -32     
+ Misses      1107     973     -134     
+ Partials       3       1       -2     
Flag Coverage Δ
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
installer-raw-app 6.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9358ca9...8717c84. Read the comment docs.

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Nov 5, 2021

@laushinka could you take a look at this small change when you're free? 🏓

Should be ok to merge but I could be missing any edge case(s) as asDashboard is used in a few other places.

@gtsiolis gtsiolis requested a review from laushinka November 5, 2021 13:01
@laushinka
Copy link
Contributor

Works as expected! And yes, "/" to "projects" already handled in the top-level routing.

/lgtm

@roboquat
Copy link
Contributor

roboquat commented Nov 5, 2021

LGTM label has been added.

Git tree hash: 932005f9da25c74e404189a6b80263d2a01a872d

@roboquat
Copy link
Contributor

roboquat commented Nov 5, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: laushinka

Associated issue: #6575

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 0d444a5 into main Nov 5, 2021
@roboquat roboquat deleted the gt/preserve-team-scope-in-dashboard branch November 5, 2021 14:47
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Nov 5, 2021

Terima kasih, @laushinka! 🏀

@laushinka
Copy link
Contributor

laushinka commented Nov 5, 2021

Terima kasih, @laushinka! 🏀

Aww, sama-sama 🥰

@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved component: dashboard deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/XS team: webapp Issue belongs to the WebApp team user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open Workspace from team context should preserve team context when returning to dashboard
3 participants