Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] Rename 'Workspaces' pages to 'My Workspaces' #6047

Closed
wants to merge 1 commit into from

Conversation

jankeromnes
Copy link
Contributor

Description

Related Issue(s)

Fixes #6045

How to test

Release Notes

[Teams] Rename 'Workspaces' pages to 'My Workspaces'

@jankeromnes jankeromnes added user experience component: dashboard type: improvement Improves an existing feature or existing code feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. labels Oct 5, 2021
@roboquat roboquat requested a review from laushinka October 5, 2021 11:12
@jankeromnes
Copy link
Contributor Author

/approve

@roboquat
Copy link
Contributor

roboquat commented Oct 5, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jankeromnes

Associated issue: #6045

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jankeromnes
Copy link
Contributor Author

jankeromnes commented Oct 5, 2021

Re-posting constructive criticism and counter-proposal from @gtsiolis on Slack (internal):

Maybe it’s just me but My XYZ feels like year 2000, no? 🤷

However, it sounds like a good boring (simple) solution. 🎯

Wondering if adjusting the header subtitles instead to be more explicit about this could help? 💭

For example, we could use the verb open to be closer to the user and maybe append an icon with a tooltip, see screenshot. 💭

Screenshot 2021-10-05 at 2 26 07 PM

I'm personally not troubled by the My XYZ pattern, and I think nobody ever reads subtitles. However, I do like the lock icon, which makes this page visually different from the others. If we go that route, I'd prefer making the lock even more visible (e.g. add it to the title instead of the subtitle).

@jldec
Copy link
Contributor

jldec commented Oct 5, 2021

Screenshots for both a user and a team dashboard page, with "My Workspaces" (based on this PR)

Screenshot 2021-10-05 at 14 29 28

Screenshot 2021-10-05 at 14 29 05

@jankeromnes
Copy link
Contributor Author

jankeromnes commented Oct 5, 2021

Excellent suggestion from @laushinka on Slack (internal):

May I also suggest putting the Workspaces tab not in the middle of Projects, Members, and Settings, but either at the start or at the end of the tab list, so the separation is clearer? I understand it’s a different issue to the renaming.

@jldec
Copy link
Contributor

jldec commented Oct 6, 2021

Suggest holding this change until we resolve #6071

@jankeromnes
Copy link
Contributor Author

jankeromnes commented Oct 7, 2021

Agree 👍

/hold

@jankeromnes
Copy link
Contributor Author

Maybe let's close this for now, and re-open a PR if this idea comes up again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved component: dashboard do-not-merge/hold feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. release-note size/XS type: improvement Improves an existing feature or existing code user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename "Workspaces" to "My Workspaces" in Team pages
3 participants