-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dashboard] Rename 'Workspaces' pages to 'My Workspaces' #6047
Conversation
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jankeromnes Associated issue: #6045 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Re-posting constructive criticism and counter-proposal from @gtsiolis on Slack (internal):
I'm personally not troubled by the My XYZ pattern, and I think nobody ever reads subtitles. However, I do like the lock icon, which makes this page visually different from the others. If we go that route, I'd prefer making the lock even more visible (e.g. add it to the title instead of the subtitle). |
Excellent suggestion from @laushinka on Slack (internal):
|
Suggest holding this change until we resolve #6071 |
Agree 👍 /hold |
Maybe let's close this for now, and re-open a PR if this idea comes up again. |
Description
Related Issue(s)
Fixes #6045
How to test
Release Notes