-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[protocol] connection: buffer messages until reconnect #5787
Conversation
5c97964
to
fd985fc
Compare
This avoids Error("Connection got disposed") errors which gobble up to the frontend and block users.
2569049
to
4f14526
Compare
@akosyakov I'm not 100% sure that this is worth the effort (code complexity, potential fallout), but her it is 🤷 😉 |
/werft run 👍 started the job as gitpod-build-gpl-5042-conn-disposed.12 |
/lgtm /hold |
LGTM label has been added. Git tree hash: 4acb2df23463a7bb5300d92035b349b5eefa590d
|
ca1c7d4
to
05f8d75
Compare
@akosyakov commented out log statements |
/lgtm |
LGTM label has been added. Git tree hash: 3a3881a7325f6905ed44f26ee3f7f7430ae27ecc
|
/unhold @geropl I think you need add approve label to merge it. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akosyakov, geropl Associated issue: #5042 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This avoids Error("Connection got disposed") errors which gobble up to the frontend and block users. Also, it makes the frontend's websocket connection more resilient in general: Instead of dropping calls, those are buffered and re-issued once the connection is reestablished.
Related Issue(s)
Fixes #5042
How to test
Login to preview env
Start a workspace
View build logs
server
)Release Notes