[projects] try to authorize if necessary #5640

AlexTugarev · 2021-09-10T07:38:12Z

This is an alternative solution to the PR #5484 where we simply use project owner's token on the backend to serve the project details. Here we will ask the current user to authorize with a provider on demand, otherwise it wont load the details.

Related Issue(s)

Fixes #5461

How to test

set up a team with 2 members (user A connected with GitLab, and user B connected with GitHub)
(user A) create a project, see the project details (Branches) are loaded
(user B) try to load project details for the same project, see a modal that enables you to authorize a missing connection

Release Notes

[Teams & Projects] Ask for authorization when viewing a project of a provider without connection

JanKoehnlein · 2021-09-10T07:59:14Z

@AlexTugarev please add a release note or NONE in the release-note block in the description of the PR to get rid of the do-not-merge/release-note-label-needed label. See https://www.notion.so/gitpod/Release-Notes-513a74fdd23b4cb1b3b3aefb1d34a3e0

gtsiolis

Thanks for giving this a go @AlexTugarev! 🗳️

gtsiolis · 2021-09-10T14:51:23Z

components/dashboard/src/projects/Project.tsx

@@ -121,6 +171,20 @@ export default function () {

    return <>
        <Header title="Branches" subtitle={<h2 className="tracking-wide">View recent active branches for <a className="text-gray-500 hover:text-gray-800 font-semibold" href={project?.cloneUrl}>{project?.name}</a>.</h2>} />
+
+        {showAuthModal && (


issue: Do we also need to use the same auth flow when opening the configuration page as the user is stuck in detecting project configuration phase?

the plan is to replicate it on the config page once it's working nicely here.

gtsiolis · 2021-09-10T14:51:58Z

components/dashboard/src/projects/Project.tsx

@@ -121,6 +171,20 @@ export default function () {

    return <>
        <Header title="Branches" subtitle={<h2 className="tracking-wide">View recent active branches for <a className="text-gray-500 hover:text-gray-800 font-semibold" href={project?.cloneUrl}>{project?.name}</a>.</h2>} />
+
+        {showAuthModal && (


question: I have access to the Prebuilds page without authorizing with the provider which also includes commit information. Expected?

Because this is all persisted on backend, yes.
Is there a problem with that?

Does not look like a problem! ✔️

components/dashboard/src/projects/Project.tsx

jankeromnes · 2021-09-24T07:29:59Z

/werft run

👍 started the job as gitpod-build-at-project-auth.12

jankeromnes · 2021-09-24T08:14:05Z

Many thanks! Taking a look now 👀

jankeromnes

Many thanks @AlexTugarev!

Code looks good to me so far (please see in-line comments), but I couldn't test the PR, as I couldn't get it deployed properly (see Slack)

Could you please rebase this Pull Request and re-deploy it with a GitHub App integration? 😬 🙏

components/dashboard/src/projects/ConfigureProject.tsx

components/dashboard/src/projects/Project.tsx

AlexTugarev · 2021-09-24T09:11:48Z

Could you please rebase this Pull Request and re-deploy it with a GitHub App integration? 😬 🙏

@jankeromnes, this isn't necessary. please try with a second account created with GitHub and visiting a project created with a first account (GitLab.) there are not specifics to GitHub which would require to set up the GH App in here. (just updated the description ☝🏻 )

AlexTugarev · 2021-09-24T13:39:45Z

/werft run

👍 started the job as gitpod-build-at-project-auth.21

🤞🏻

gtsiolis · 2021-09-29T12:16:05Z

For the Configurator, I couldn't find a spec. @gtsiolis does the current state look okay? 🙂

Thanks for noticing, @jankeromnes! There wasn't a spec for the configurator specifically but the current state looks good.

🍊 🍊 🍊 🍊

thought: I think using non-modal approach makes the flow less distruptive and more aligned with the rest of the product.

For example, we don't use a modal to ask for authorization when needed (e.g. workspace loading screen) and using a modal could require us to render empty pages behind the modal (e.g empty branches list) which could look strange in terms of UX.

Also, the already existing non-modal auth flow when adding a project, which is using the same pattern with the gray background to ask for user input or authorization, helps build a muscle memory across the product. 💭

New project auth	Access branches auth

I'd love to hear any feedback on this. Cc @AlexTugarev @jankeromnes

Co-authored-by: Jan Keromnes <[email protected]>

jankeromnes · 2021-09-29T15:04:28Z

(Please also feel free to tick the completed checkboxes here and here, and to re-request a review when relevant 😊 happy to help!)

AlexTugarev · 2021-09-30T10:52:52Z

@gtsiolis and @jankeromnes, what's left here to proceed?

AlexTugarev · 2021-09-30T10:53:21Z

/werft run

👍 started the job as gitpod-build-at-project-auth.34

jankeromnes · 2021-09-30T10:55:38Z

@gtsiolis and @jankeromnes, what's left here to proceed?

From my side, nothing left! 🎉 Thanks a lot for following up. 🙏

I'm happy to take another look in about an hour and approve.

jankeromnes

Perfection ✨ ☺️

Code looks good to me (especially with ?w=1) and works as advertised! 🎉

One small error, but seems unrelated to this PR (i.e. maybe a follow-up?) -- When creating a new project as a new Member (i.e. not an Owner), I see an alert about not being authorized to create the project, however the project is created anyway? 😳 That's confusing. And when being upgraded from Member to Owner, the error on creation no longer shows up.

To reproduce:

set up a team with 2 members (user A connected with GitHub, invites as "Member" user B connected with GitLab)
(user B) try create a project from a GitLab repository, see error alert
(user B) going to the Projects list, see that the project was actually created anyway

roboquat · 2021-09-30T12:49:08Z

LGTM label has been added.

Git tree hash: fcb8d1b6cdb18568cdad35f854f8ab6484525834

gtsiolis · 2021-09-30T12:52:40Z

One small error, ...

Great catch, @jankeromnes! I was able to reproduce this on staging and production. Upvoting for a follow-up issue. ⚾

AlexTugarev · 2021-09-30T13:41:02Z

@jankeromnes, good catch

https://console.cloud.google.com/logs/query;cursorTimestamp=2021-09-30T12:39:50.902Z;query=resource.type%3D%22k8s_container%22%0Aresource.labels.project_id%3D%22gitpod-core-dev%22%0Aresource.labels.location%3D%22europe-west1-b%22%0Aresource.labels.cluster_name%3D%22core-dev%22%0Aresource.labels.namespace_name%3D%22staging-at-project-auth%22%0Alabels.k8s-pod%2Fapp%3D%22gitpod%22%0Alabels.k8s-pod%2Fcomponent%3D%22server%22%0Alabels.k8s-pod%2Fkind%3D%22pod%22%0Alabels.k8s-pod%2Fstage%3D%22devstaging%22%0A-jsonPayload.message%3D%22error%20sending%20spans%20over%20HTTP:%20Error:%20getaddrinfo%20ENOTFOUND%20jaeger-collector%22%0A-jsonPayload.message%3D%22Failed%20to%20flush%20spans%20in%20reporter:%20error%20sending%20spans%20over%20HTTP:%20Error:%20getaddrinfo%20ENOTFOUND%20jaeger-collector%22%0Atimestamp%3D%222021-09-30T12:39:07.295Z%22%0AinsertId%3D%22hpqzj7svsuwaim48%22?project=gitpod-core-dev

Update: @jankeromnes, please try to reproduce on staging or prod 🙏🏻 I followed your steps, but I couldn't reproduce. Actually it looks really like a token issue, it seems that your gitlab.com token was not found 🤷🏻‍♂️

AlexTugarev · 2021-09-30T13:52:52Z

/approve no-issue

roboquat · 2021-09-30T13:52:59Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexTugarev, jankeromnes

Associated issue: #5461

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~components/dashboard/OWNERS~~ [AlexTugarev,jankeromnes]
~~components/server/OWNERS~~ [AlexTugarev,jankeromnes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

follow up for #5640

roboquat added the do-not-merge/work-in-progress label Sep 10, 2021

roboquat requested a review from JanKoehnlein September 10, 2021 07:38

roboquat added do-not-merge/release-note-label-needed size/M labels Sep 10, 2021

AlexTugarev force-pushed the at/project-auth branch 5 times, most recently from 8333a76 to c83d0e6 Compare September 10, 2021 13:18

AlexTugarev marked this pull request as ready for review September 10, 2021 13:25

roboquat removed the do-not-merge/work-in-progress label Sep 10, 2021

AlexTugarev requested review from gtsiolis and svenefftinge and removed request for JanKoehnlein September 10, 2021 13:35

gtsiolis reviewed Sep 10, 2021

View reviewed changes

AlexTugarev force-pushed the at/project-auth branch 3 times, most recently from 9b2499f to dfe9de6 Compare September 14, 2021 10:29

roboquat added size/XL and removed size/M labels Sep 14, 2021

AlexTugarev force-pushed the at/project-auth branch from f9045c7 to ffc6905 Compare September 14, 2021 11:16

AlexTugarev force-pushed the at/project-auth branch from ffc6905 to adda6dc Compare September 23, 2021 12:40

AlexTugarev requested a review from jankeromnes September 23, 2021 12:41

jankeromnes reviewed Sep 24, 2021

View reviewed changes

components/dashboard/src/projects/ConfigureProject.tsx Show resolved Hide resolved

components/dashboard/src/projects/ConfigureProject.tsx Outdated Show resolved Hide resolved

components/dashboard/src/projects/Project.tsx Show resolved Hide resolved

AlexTugarev force-pushed the at/project-auth branch from 700bfc0 to 8bc6469 Compare September 24, 2021 09:07

[projects] try to authorize if necessary

c19ef64

Co-authored-by: Jan Keromnes <[email protected]>

AlexTugarev force-pushed the at/project-auth branch from 1e21f41 to c19ef64 Compare September 29, 2021 14:09

roboquat added size/XXL and removed size/XL labels Sep 29, 2021

AlexTugarev requested a review from gtsiolis September 29, 2021 14:10

AlexTugarev requested a review from jankeromnes September 30, 2021 06:41

jankeromnes approved these changes Sep 30, 2021

View reviewed changes

roboquat assigned jankeromnes Sep 30, 2021

roboquat added the lgtm label Sep 30, 2021

roboquat added release-note and removed do-not-merge/release-note-label-needed labels Sep 30, 2021

roboquat added the approved label Sep 30, 2021

roboquat merged commit b0e5bf6 into main Sep 30, 2021

roboquat deleted the at/project-auth branch September 30, 2021 13:53

AlexTugarev added a commit that referenced this pull request Oct 1, 2021

[projects] fix for empty projects page

964e6a3

follow up for #5640

AlexTugarev mentioned this pull request Oct 1, 2021

[projects] fix for empty projects page #5973

Merged

roboquat pushed a commit that referenced this pull request Oct 1, 2021

[projects] fix for empty projects page

8e9f2fd

follow up for #5640

gtsiolis added feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. component: dashboard team: webapp Issue belongs to the WebApp team labels Oct 1, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[projects] try to authorize if necessary #5640

[projects] try to authorize if necessary #5640

AlexTugarev commented Sep 10, 2021 •

edited

Loading

JanKoehnlein commented Sep 10, 2021

gtsiolis left a comment

gtsiolis Sep 10, 2021

AlexTugarev Sep 13, 2021

gtsiolis Sep 10, 2021

AlexTugarev Sep 13, 2021

gtsiolis Sep 29, 2021

jankeromnes commented Sep 24, 2021 •

edited by werft-gitpod-dev-com bot

Loading

jankeromnes commented Sep 24, 2021 •

edited by werft-gitpod-dev-com bot

Loading

jankeromnes left a comment

AlexTugarev commented Sep 24, 2021 •

edited

Loading

AlexTugarev commented Sep 24, 2021 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis commented Sep 29, 2021 •

edited by werft-gitpod-dev-com bot

Loading

jankeromnes commented Sep 29, 2021 •

edited

Loading

AlexTugarev commented Sep 30, 2021

AlexTugarev commented Sep 30, 2021 •

edited by werft-gitpod-dev-com bot

Loading

jankeromnes commented Sep 30, 2021 •

edited by werft-gitpod-dev-com bot

Loading

jankeromnes left a comment •

edited

Loading

roboquat commented Sep 30, 2021

gtsiolis commented Sep 30, 2021 •

edited by werft-gitpod-dev-com bot

Loading

AlexTugarev commented Sep 30, 2021 •

edited

Loading

AlexTugarev commented Sep 30, 2021

roboquat commented Sep 30, 2021

[projects] try to authorize if necessary #5640

[projects] try to authorize if necessary #5640

Conversation

AlexTugarev commented Sep 10, 2021 • edited Loading

Related Issue(s)

How to test

Release Notes

JanKoehnlein commented Sep 10, 2021

gtsiolis left a comment

Choose a reason for hiding this comment

gtsiolis Sep 10, 2021

Choose a reason for hiding this comment

AlexTugarev Sep 13, 2021

Choose a reason for hiding this comment

gtsiolis Sep 10, 2021

Choose a reason for hiding this comment

AlexTugarev Sep 13, 2021

Choose a reason for hiding this comment

gtsiolis Sep 29, 2021

Choose a reason for hiding this comment

jankeromnes commented Sep 24, 2021 • edited by werft-gitpod-dev-com bot Loading

jankeromnes commented Sep 24, 2021 • edited by werft-gitpod-dev-com bot Loading

jankeromnes left a comment

Choose a reason for hiding this comment

AlexTugarev commented Sep 24, 2021 • edited Loading

AlexTugarev commented Sep 24, 2021 • edited by werft-gitpod-dev-com bot Loading

gtsiolis commented Sep 29, 2021 • edited by werft-gitpod-dev-com bot Loading

jankeromnes commented Sep 29, 2021 • edited Loading

AlexTugarev commented Sep 30, 2021

AlexTugarev commented Sep 30, 2021 • edited by werft-gitpod-dev-com bot Loading

jankeromnes commented Sep 30, 2021 • edited by werft-gitpod-dev-com bot Loading

jankeromnes left a comment • edited Loading

Choose a reason for hiding this comment

roboquat commented Sep 30, 2021

gtsiolis commented Sep 30, 2021 • edited by werft-gitpod-dev-com bot Loading

AlexTugarev commented Sep 30, 2021 • edited Loading

AlexTugarev commented Sep 30, 2021

roboquat commented Sep 30, 2021

AlexTugarev commented Sep 10, 2021 •

edited

Loading

jankeromnes commented Sep 24, 2021 •

edited by werft-gitpod-dev-com bot

Loading

jankeromnes commented Sep 24, 2021 •

edited by werft-gitpod-dev-com bot

Loading

AlexTugarev commented Sep 24, 2021 •

edited

Loading

AlexTugarev commented Sep 24, 2021 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis commented Sep 29, 2021 •

edited by werft-gitpod-dev-com bot

Loading

jankeromnes commented Sep 29, 2021 •

edited

Loading

AlexTugarev commented Sep 30, 2021 •

edited by werft-gitpod-dev-com bot

Loading

jankeromnes commented Sep 30, 2021 •

edited by werft-gitpod-dev-com bot

Loading

jankeromnes left a comment •

edited

Loading

gtsiolis commented Sep 30, 2021 •

edited by werft-gitpod-dev-com bot

Loading

AlexTugarev commented Sep 30, 2021 •

edited

Loading