[projects] fix search input on /new #5375
Conversation
AlexTugarev
requested review from
atduarte and
gtsiolis
and removed request for
laushinka
|
Looking at this now! 👀 |
There was a problem hiding this comment.
UX works like a charm! 🔮
Thanks for picking this up @AlexTugarev!
We're now one step closer to shipping Teams & Projects! 🚢
|
LGTM label has been added. Git tree hash: 03c5caaf14285cca47fbbbf58083bba13b5af424
|
AlexTugarev
force-pushed
the
at/fix-search-input
branch
from
ed18974 to
f637a59
Compare
|
/hold |
|
@gtsiolis I pushed another small fix. turns out the search filter was case sensitive. it's fixed now. |
| @@ -214,9 +214,11 @@ export default function NewProject() { | |||
| const renderSelectRepository = () => { | |||
|
|
|||
| const noReposAvailable = reposInAccounts.length === 0; | |||
| const filteredRepos = Array.from(reposInAccounts).filter(r => r.account === selectedAccount && r.name.includes(repoSearchFilter)); | |||
| const filteredRepos = Array.from(reposInAccounts).filter(r => r.account === selectedAccount && `${r.name}`.toLowerCase().includes(repoSearchFilter.toLowerCase())); | |||
There was a problem hiding this comment.
praise: Thanks so much for fixing this! I was wondering why some projects were not included in the search results when using some lowercase letters. ❗
|
LGTM label has been added. Git tree hash: f977a64fbdfb008db9ac191e9f5f428957182fa1
|
|
/hold cancel |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlexTugarev, gtsiolis Associated issue: #5373 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #5373