Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-manager] Ensure status before setting phase tag #5294

Merged
merged 1 commit into from
Aug 23, 2021
Merged

[ws-manager] Ensure status before setting phase tag #5294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/ws-manager/pkg/manager/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,8 +369,8 @@ func (m *Manager) stopWorkspace(ctx context.Context, workspaceID string, gracePe
}

status, _ := m.getWorkspaceStatus(workspaceObjects{Pod: pod})
span.SetTag("phase", status.Phase)
if status != nil {
span.SetTag("phase", status.Phase)
// If the status is nil (e.g. because an error occured), we'll still try and stop the workspace
// This is merely an optimization that prevents deleting the workspace pod multiple times.
// If we do try and delete the pod a few times though, that's ok, too.
Expand Down