Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gitpod-protocol] Remove deprecated and unused errors and cleanup logs #5173

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

@roboquat roboquat requested a review from svenefftinge August 12, 2021 13:19
@aledbf
Copy link
Member Author

aledbf commented Aug 12, 2021

/assign @csweichel

@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #5173 (af4e82b) into main (92deb3d) will increase coverage by 31.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #5173       +/-   ##
=========================================
+ Coverage      0   31.36%   +31.36%     
=========================================
  Files         0       35       +35     
  Lines         0     5819     +5819     
=========================================
+ Hits          0     1825     +1825     
- Misses        0     3846     +3846     
- Partials      0      148      +148     
Flag Coverage Δ
components-ee-agent-smith-app 26.12% <ø> (?)
components-gitpod-cli-app 9.74% <ø> (?)
components-gitpod-protocol-go-lib ∅ <ø> (?)
components-local-app-app-darwin ∅ <ø> (?)
components-local-app-app-linux ∅ <ø> (?)
components-local-app-app-windows ∅ <ø> (?)
components-supervisor-app 37.41% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/supervisor/pkg/terminal/terminal.go 63.27% <0.00%> (ø)
components/gitpod-cli/cmd/root.go 0.00% <0.00%> (ø)
components/gitpod-cli/cmd/completion.go 40.00% <0.00%> (ø)
components/supervisor/pkg/dropwriter/dropwriter.go 73.46% <0.00%> (ø)
components/ee/agent-smith/pkg/agent/agent.go 19.04% <0.00%> (ø)
components/supervisor/pkg/supervisor/services.go 25.50% <0.00%> (ø)
components/supervisor/pkg/terminal/service.go 29.09% <0.00%> (ø)
components/gitpod-cli/cmd/preview.go 32.14% <0.00%> (ø)
components/supervisor/pkg/supervisor/git.go 0.00% <0.00%> (ø)
components/supervisor/pkg/supervisor/tasks.go 55.22% <0.00%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92deb3d...af4e82b. Read the comment docs.

@csweichel
Copy link
Contributor

/approve no-issue

@csweichel
Copy link
Contributor

/lgtm

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel

Associated issue requirement bypassed by: csweichel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 354572d07848ec29f0a604bf200ae0f97105671d

@roboquat roboquat merged commit f443340 into main Aug 12, 2021
@roboquat roboquat deleted the aledbf/warn branch August 12, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants