-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[agent-smith] Support CPU limit penalties #5097
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5097 +/- ##
=========================================
+ Coverage 0 31.20% +31.20%
=========================================
Files 0 70 +70
Lines 0 14772 +14772
=========================================
+ Hits 0 4610 +4610
- Misses 0 9744 +9744
- Partials 0 418 +418
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
aefc69e
to
7a92d47
Compare
/approve |
/lgtm |
LGTM label has been added. Git tree hash: cf02e5cd582096af1e13ba516ae7808c48f011be
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csweichel, JanKoehnlein Associated issue: #5070 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fixes #5070
This PR plugs agent-smith back into Kubernetes to re-establish the limit CPU penalty.
When this penalty is enforced, we set an annotation on the pod which causes ws-daemon to update the cgroup.
Note: renaming from
gitpod/cpuLimit
togitpod.io/cpuLimit
is inconsequential to existing workspaces because of the way we roll this change out. I.e. when we roll it out we do so on an empty cluster, hence there are no existing workspaces.