Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[agent-smith] Support CPU limit penalties #5097

Merged
merged 1 commit into from
Aug 9, 2021
Merged

[agent-smith] Support CPU limit penalties #5097

merged 1 commit into from
Aug 9, 2021

Conversation

csweichel
Copy link
Contributor

fixes #5070

This PR plugs agent-smith back into Kubernetes to re-establish the limit CPU penalty.
When this penalty is enforced, we set an annotation on the pod which causes ws-daemon to update the cgroup.

Note: renaming from gitpod/cpuLimit to gitpod.io/cpuLimit is inconsequential to existing workspaces because of the way we roll this change out. I.e. when we roll it out we do so on an empty cluster, hence there are no existing workspaces.

@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #5097 (7a92d47) into main (f16d4fe) will increase coverage by 31.20%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #5097       +/-   ##
=========================================
+ Coverage      0   31.20%   +31.20%     
=========================================
  Files         0       70       +70     
  Lines         0    14772    +14772     
=========================================
+ Hits          0     4610     +4610     
- Misses        0     9744     +9744     
- Partials      0      418      +418     
Flag Coverage Δ
components-content-service-app 14.47% <ø> (?)
components-content-service-lib 14.47% <ø> (?)
components-image-builder-app 34.44% <ø> (?)
components-image-builder-mk3-app 6.72% <ø> (?)
components-supervisor-app 36.16% <ø> (?)
components-ws-daemon-app 23.00% <ø> (?)
components-ws-manager-app 36.32% <ø> (?)
components-ws-proxy-app 67.13% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ws-daemon/pkg/content/initializer.go 0.00% <0.00%> (ø)
components/ws-manager/pkg/manager/manager.go 24.89% <0.00%> (ø)
components/ws-proxy/pkg/proxy/proxy.go 30.35% <0.00%> (ø)
components/ws-manager/pkg/manager/status.go 71.96% <0.00%> (ø)
components/ws-manager/pkg/manager/monitor.go 0.00% <0.00%> (ø)
...onents/content-service/pkg/initializer/download.go 76.31% <0.00%> (ø)
components/ws-daemon/pkg/content/config.go 62.50% <0.00%> (ø)
...ents/image-builder-mk3/pkg/orchestrator/monitor.go 11.80% <0.00%> (ø)
components/ws-manager/pkg/manager/probe.go 0.00% <0.00%> (ø)
components/ws-manager/pkg/manager/annotations.go 66.66% <0.00%> (ø)
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f16d4fe...7a92d47. Read the comment docs.

@roboquat roboquat added the size/L label Aug 6, 2021
@csweichel
Copy link
Contributor Author

/approve

@JanKoehnlein
Copy link
Contributor

/lgtm

@roboquat
Copy link
Contributor

roboquat commented Aug 9, 2021

LGTM label has been added.

Git tree hash: cf02e5cd582096af1e13ba516ae7808c48f011be

@roboquat
Copy link
Contributor

roboquat commented Aug 9, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel, JanKoehnlein

Associated issue: #5070

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 631322b into main Aug 9, 2021
@roboquat roboquat deleted the cw/as-limitcpu branch August 9, 2021 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agent Smith LimitCPUUse method doesn't do anything
3 participants