Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update right menu style #5074

Merged
merged 1 commit into from
Aug 5, 2021
Merged

Update right menu style #5074

merged 1 commit into from
Aug 5, 2021

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Aug 5, 2021

This will resolve some inconsistencies on the font size used across the top level navigation menus.

Resolve the outstanding points in #4471.

BEFORE AFTER
menu-before menu-after

@roboquat roboquat requested a review from laushinka August 5, 2021 14:46
@gtsiolis gtsiolis linked an issue Aug 5, 2021 that may be closed by this pull request
5 tasks
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Aug 5, 2021

@jankeromnes could you take a look at this one-line change since you were involved in #4471?

/assign @jankeromnes

@gtsiolis gtsiolis requested review from jankeromnes and removed request for laushinka August 5, 2021 14:48
Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Muchas gracias 🙏

/approve

@roboquat roboquat added the lgtm label Aug 5, 2021
@roboquat
Copy link
Contributor

roboquat commented Aug 5, 2021

LGTM label has been added.

Git tree hash: 281bed9460bab0713f92c45ccfeb1fb914eee7d0

@roboquat
Copy link
Contributor

roboquat commented Aug 5, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jankeromnes

Associated issue: #4471

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit d4c5800 into main Aug 5, 2021
@roboquat roboquat deleted the gt/update-right-menu-style branch August 5, 2021 15:08
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Aug 5, 2021

De nada @jankeromnes! Thanks! ⚾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Teams] Adjust styling of Teams menu & pages
3 participants