[dashboard] Allow Projects for Individuals

[jankeromnes]

Fixes #4920

[jankeromnes]

@AlexTugarev Okay, I believe I've now fixed all the Teams & Project URLs (they all now use either /${team.slug}/... or /projects/... as slug, depending on team- vs user-project).

I've also adjusted the top menu to work with individual projects as well, and I've made sure every page sets a window title (by slightly abusing the Header component).

Please take another look + test again (deployment already has GH app) + let me know what you think! 🙏

[AlexTugarev]

Comments/notes:

• in general: having Projects under personal account is neat and it feels natural! 👍🏻
• 🎉 thanks for fixing the window.title issue 💯
• question: why is re-selecting of the personal account from the top menu navigating to /workspaces and not /projects? this is different with teams. still undecided, I'm not against it, just trying to understand the difference ;-)
• when opening the New Project wizard from the personal Projects page (New Project button below) it will ask me for the team. This is not the case when starting out from a team's Projects page. This seems to be inconsistent. Let's decide on a single strategy here. Maybe @gtsiolis can assist here?

* `Rerun Prebuild` seems to be coined to teams. At least it fails with `No team found`

[gtsiolis]

why is re-selecting of the personal account from the top menu navigating to /workspaces and not /projects?

@AlexTugarev I agree that eventually this could probably default to /projects just like with any other team. See also #4966 (comment). It could be fine to also fix this in a smaller and separate PR if needed.

🍊 🍊 🍊 🍊

This is not the case when starting out from a team's Projects page. This seems to be inconsistent. Let's decide on a single strategy here. Maybe @gtsiolis can assist here?

When a user tries to create a project from within a team page it could make sense to automatically associate that project with the team they were looking at, right?

suggestion: When 🅰️ going though the onboarding flow (/new) or 🅱️ having the personal account selected, it could make sense for both cases to promt the user for a team selection including the personal account as a team option as seen in the relevant specs in #4948, see Select Team. Cross-posting below the relevant spec. Feel free to ignore the footnote about Teams & Projects pricing. What do you think? ❓ See also relevant discussion.

Team Selection for New Projects under Personal Account

[svenefftinge]

when opening the New Project wizard from the personal Projects page (New Project button below) it will ask me for the team. This is not the case when starting out from a team's Projects page. This seems to be inconsistent. Let's decide on a single strategy here.

I think it is good to ask in one but not the other case, because we want to help users put their projects below teams. So it makes sense to suggest it in that case. When I crate a project from a team there is no need to ask users to choose another team.

[AlexTugarev]

After double-checking with gitpod-staging.com, it seems prebuilds aren't working here. I cannot see prebuilds running. Server logs do indicate prebuild registration, but there aren't any. @jankeromnes, could you check the webhook URL, please?

[jankeromnes]

Many thanks for the reviews!!

After double-checking with gitpod-staging.com, it seems prebuilds aren't working here. I cannot see prebuilds running. Server logs do indicate prebuild registration, but there aren't any. @jankeromnes, could you check the webhook URL, please?

Interesting. With my integration, I was able to trigger a prebuild by:

1. Installing the app janx-gitpod on https://github.com/jankeromnes/gitpod-staging-prebuilds (while creating a new Project)
2. Creating a new Pull Request (i.e. branch) on that repository
3. See the new prebuild appear in the Prebuilds list

Not sure why you didn't see prebuilds. Maybe the janx-gitpod app wasn't installed on the repository you tried with? Or could be a different problem in this PR? (No idea where to look, but I could test again tomorrow -- also I believe the webhook URLs were correct and still are correct.)

---

Also, what items are still blocking this PR from being merged?

• The "onboarding flow asks for which team when creating from user" inconsistency was brought up (because when creating from a team, the onboarding flow does not ask & pre-selects the relevant team). However, Sven pointed out that the inconsistency is desirable (asking again when creating from a user encourages people to create teams, which is what we prefer). So, no action required here.

• The "projects is the default tab for teams, but not for users" inconsistency was brought up. This should likely be fixed in the future (i.e. maybe Projects also the default tab for users), however doing that now is impractical, because of the Teams & Projects UI on/off flag (when off, we don't want a default page that "doesn't exist"). So, maybe we fix this later, when Teams & Projects is enabled generally.

• Prebuilds didn't work for Alex. Jan can try to test prebuilds again tomorrow.

• ... anything else still blocking a lgtm? 😇

[jankeromnes]

Gitpod deployment, I summon thee! 🧙

/werft run

👍 started the job as gitpod-build-jx-user-projects.28

[svenefftinge]

anything else still blocking a lgtm? 😇

FWIW, to me it lVerygtm 🎉 when I tested it yesterday and looked over the code, but since you had intense conversations with Alex, I think he should do the approval.

[AlexTugarev]

• Rerun Prebuild seems to be coined to teams. At least it fails with No team found

@jankeromnes, this still fails.

[AlexTugarev]

🎉 Prebuilds are shown in personal and team project!

[jankeromnes]

Woohoo! Thanks Alex! 🎉

(To be safe, I even recorded a quick screencast to demo prebuilds in action 😁 but I guess it's no longer needed!)

• Rerun Prebuild seems to be coined to teams. At least it fails with No team found

Oh! I totally overlooked this comment. 🙈 Will check & fix.

[AlexTugarev]

/lgtm 👍🏻 👍🏻 👍🏻

/hold @jankeromnes, please have a look at the last two comments of mine.

[roboquat]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexTugarev

Associated issue: #4920

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• components/dashboard/OWNERS [AlexTugarev]
• components/gitpod-db/OWNERS [AlexTugarev]
• components/gitpod-protocol/OWNERS [AlexTugarev]
• components/server/OWNERS [AlexTugarev]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jankeromnes]

Fixed the two nits, and added a dependency on teams for all "project-loading effects": https://github.com/gitpod-io/gitpod/compare/df93235422df3d3646f4e7f565c3d644eaa4d11a..98080ef4db388dfc0acec48e779ba416894f7bf8

Carrying over the /lgtm from #4966 (comment) 😇