Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-proxy] Skip DNS errors when workspace is not available #4954

Merged
merged 1 commit into from
Jul 26, 2021

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jul 26, 2021

Screenshot from 2021-07-26 09-42-29

@aledbf
Copy link
Member Author

aledbf commented Jul 26, 2021

/assign @csweichel

@csweichel
Copy link
Contributor

/LGTM

@roboquat roboquat added the lgtm label Jul 26, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: f14c216890b3882d6fe946f5303cac29e399bbf1

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, csweichel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #4954 (8293613) into main (89db73e) will increase coverage by 67.13%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #4954       +/-   ##
=========================================
+ Coverage      0   67.13%   +67.13%     
=========================================
  Files         0        8        +8     
  Lines         0     1272     +1272     
=========================================
+ Hits          0      854      +854     
- Misses        0      360      +360     
- Partials      0       58       +58     
Flag Coverage Δ
components-ws-proxy-app 67.13% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ws-proxy/pkg/proxy/pass.go 74.40% <0.00%> (ø)
components/ws-proxy/pkg/proxy/routes.go 83.64% <0.00%> (ø)
components/ws-proxy/pkg/proxy/workspacerouter.go 81.73% <0.00%> (ø)
components/ws-proxy/pkg/proxy/cookies.go 78.57% <0.00%> (ø)
components/ws-proxy/pkg/proxy/infoprovider.go 50.34% <0.00%> (ø)
components/ws-proxy/pkg/proxy/config.go 0.00% <0.00%> (ø)
components/ws-proxy/pkg/proxy/auth.go 100.00% <0.00%> (ø)
components/ws-proxy/pkg/proxy/proxy.go 30.35% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89db73e...8293613. Read the comment docs.

@roboquat roboquat merged commit f6aea00 into main Jul 26, 2021
@roboquat roboquat deleted the aledbf/proxyerr branch July 26, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants