Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bridge] Fix removal of "has-permission" admission constraint #4821

Merged
merged 1 commit into from
Jul 15, 2021

Conversation

geropl
Copy link
Member

@geropl geropl commented Jul 14, 2021

Fixes #4272.

Test

  1. Start a workspace on this branch
  2. execute the following script
cd dev/gpctl
go build -v .
./gpctl clusters get-tls-config
./gpctl clusters --name ws-dev register --hint-govern --tls-path=./wsman-tls --url ws-manager:8080
./gpctl clusters list
./gpctl clusters update admission-constraint --name ws-dev add has-permission="test"
./gpctl clusters list
./gpctl clusters update admission-constraint --name ws-dev remove has-permission="test"
./gpctl clusters list

@geropl
Copy link
Member Author

geropl commented Jul 15, 2021

/werft run

👍 started the job as gitpod-build-gpl-gpctl-remove-admission.2

@geropl geropl marked this pull request as ready for review July 15, 2021 09:23
@geropl geropl requested review from a team, JanKoehnlein and meysholdt and removed request for a team July 15, 2021 09:23
Copy link
Member

@meysholdt meysholdt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it. Works as advertised. Thank you!

@geropl geropl merged commit 64289ce into main Jul 15, 2021
@geropl geropl deleted the gpl/gpctl-remove-admission branch July 15, 2021 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gpctl clusters update admission-constraint remove does not work
2 participants