Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[code] complete validations of extensions in .gitpod.yml #4646

Merged
merged 1 commit into from
Jun 29, 2021
Merged

[code] complete validations of extensions in .gitpod.yml #4646

merged 1 commit into from
Jun 29, 2021

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Jun 29, 2021 •
edited
Loading

  • /werft with-clean-slate-deployment

What it does

Change in Gitpod Code: gitpod-io/openvscode-server@5007ab7

There are now following validations and quick fixes:

Check Quick Fixes 
Deprecated user uploaded extensions Resolve them against Open VSX 
 Extensions cannot be found in Open VSX Remove from .gitpod.yml or search for them in Open VSX 
 Extensions URLs cannot be resolved to valid VSIX files Remove from .gitpod.yml 
 Extensions is installed for the workspace but missing in .gitpod.yml  Add to .gitpod.yml or uninstall
 Extensions is uninstalled but present in .gitpod.yml  Remove from .gitpod.yml or install as no synced

How to test

vscode:
  extensions:
    - [email protected]:UATTe2sTFfCYWQ3jw4IRsw==
    - [email protected]:ZnPmyF/Pb8AIWeCqc83gPw==
    - [email protected]:j58HdmA0K7d9a9sEkogZNw==
    - [email protected]:uXdjV53wtoTevFK6HOh3pQ==
    - [email protected]:QEP7gdWtMuY+j8RZ5OLDkA==
    - [email protected]:yEx8nRSXlfXAHqsbkTJpdA==
    - [email protected]:Z3iqHRuIxskc0nruY4MpEQ==
    - https://github.com/golang/vscode-go/releases/download/v0.26.0/go-0.26.0.vsix
    - https://github.com/golang/vscode-go/releases/download2/v0.26.0/go-0.26.222.vsix
  • Play with it, try to install and uninstall some extensions, and check that validations (quick fixes) pop up as described above.

@akosyakov akosyakov mentioned this pull request Jun 29, 2021
Closed
@akosyakov akosyakov marked this pull request as draft June 29, 2021 07:46
@akosyakov akosyakov force-pushed the ak/complete_ext_validate branch from 5261b64 to 96b826d Compare June 29, 2021 08:11
@akosyakov akosyakov force-pushed the ak/complete_ext_validate branch from 96b826d to 47f5a1f Compare June 29, 2021 08:26
@akosyakov akosyakov marked this pull request as ready for review June 29, 2021 09:01
@akosyakov akosyakov requested a review from JanKoehnlein June 29, 2021 09:02
JanKoehnlein
JanKoehnlein approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@JanKoehnlein JanKoehnlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akosyakov akosyakov merged commit 2863fa8 into main Jun 29, 2021
@akosyakov akosyakov deleted the ak/complete_ext_validate branch June 29, 2021 10:04
@akosyakov akosyakov mentioned this pull request Nov 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanKoehnlein JanKoehnlein JanKoehnlein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[code] validate that uninstalled no sync extensions are removed from .gitpod.yml
2 participants
@akosyakov @JanKoehnlein