Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard] Don't close modal when click outside #4437

Merged
merged 1 commit into from
Jun 8, 2021
Merged

[dashboard] Don't close modal when click outside #4437

merged 1 commit into from
Jun 8, 2021

Conversation

corneliusludmann
Copy link
Contributor

Fixes #4221

JanKoehnlein
JanKoehnlein approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@JanKoehnlein JanKoehnlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corneliusludmann corneliusludmann merged commit 0e03969 into main Jun 8, 2021
@corneliusludmann corneliusludmann deleted the corneliusludmann/dashboard-settings-4221 branch June 8, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanKoehnlein JanKoehnlein JanKoehnlein approved these changes

Assignees
No one assigned
Labels
component: dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dashboard/settings/variables: ending drag selection outside of modal dialog dismisses dialog
3 participants
@corneliusludmann @JanKoehnlein @gtsiolis