Improve hostname validation #4118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geropl
reviewed
Apr 30, 2021
| @@ -18,7 +18,7 @@ import { BitbucketTokenHelper } from "./bitbucket-token-handler"; | |||
| const expect = chai.expect; | |||
| import { skipIfEnvVarNotSet } from "@gitpod/gitpod-protocol/lib/util/skip-if"; | |||
|
|
|||
| @suite.only(timeout(10000), skipIfEnvVarNotSet("GITPOD_TEST_TOKEN_BITBUCKET")) | |||
geropl
reviewed
Apr 30, 2021
| const workspaceId = url.workspaceId; | ||
| if (workspaceId) { | ||
| const hostname = url.url.hostname as string; | ||
| if (hostname.startsWith(workspaceId)) { |
There was a problem hiding this comment.
Would be nice if we had one place for the workspace URL parsing. But might be out of scope for this PR, as it was here before, too.
There was a problem hiding this comment.
GitpodHostUrl does the URL parsing. Here we explicitly check, that the workspace-like hostname is not prefixed.
Ah, perhaps you mean to extract the computation of the prefix and move it to GitpodHostUrl? 🤷🏻♂️
geropl
approved these changes
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.