Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] Redirect to /blocked when trying to create or start a workspace while blocked #3785

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

jankeromnes
Copy link
Contributor

@jankeromnes jankeromnes commented Apr 6, 2021

Fixes #3783

@jankeromnes jankeromnes force-pushed the jx/redirect-blocked branch from 9445bf2 to b0803d4 Compare April 7, 2021 06:53
@jankeromnes jankeromnes force-pushed the jx/redirect-blocked branch 4 times, most recently from ae3f120 to 23be9ae Compare April 9, 2021 11:43
@jankeromnes jankeromnes marked this pull request as ready for review April 9, 2021 11:53
@jankeromnes
Copy link
Contributor Author

jankeromnes commented Apr 9, 2021

How to test:

In both cases, you should get quickly redirected to /blocked:

Screenshot 2021-04-09 at 14 00 14

@jankeromnes jankeromnes force-pushed the jx/redirect-blocked branch 2 times, most recently from c03679c to f050f51 Compare April 9, 2021 12:10
@jankeromnes
Copy link
Contributor Author

jankeromnes commented Apr 9, 2021

@gtsiolis or @AlexTugarev, please take a look if you have time 😊 (Priority: 🔅 Low)

@AlexTugarev
Copy link
Member

Screen Shot 2021-04-09 at 17 56 07

redirect on blocked state worked!

@jankeromnes jankeromnes force-pushed the jx/redirect-blocked branch from f050f51 to 9600e6d Compare April 9, 2021 16:26
@jankeromnes jankeromnes requested a review from AlexTugarev April 9, 2021 16:29
Copy link
Member

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Blocked] Redirect to /blocked when trying to create or start a workspace while blocked
3 participants