-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[analytics] add error field to feedback event #10455
Conversation
/werft run 👍 started the job as gitpod-build-laushinka-send-error-message-with-10402.1 |
I think we should try to include the actual error text in the feedback report Information about the context would be good too e.g. to tell the difference between 404 errors in say |
4482529
to
b27e593
Compare
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
b27e593
to
811ca8e
Compare
started the job as gitpod-build-laushinka-send-error-message-with-10402.4 because the annotations in the pull request description changed |
@laushinka I rebased and updated the werft flags in the description |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This implementation works, but it is incomplete because the error message text is not included with the feedback. Currently, error handling implementations e.g. in CreateWorkspace.tsx render errors directly to HTML, instead of starting with plaintext first, and then rendering it. |
9392116
to
6f1e5db
Compare
Closing because too stale. Picked up here. |
Description
[@jldec updated Aug 17, 2022]
The intent of this PR was to add the rendered error message along with the feedback tracking event, however, the object used in this implementation does not actually include the rendered error message, because that is derived in JSX.
Related Issue(s)
Fixes #10402
How to test
feedback_submitted
.error_rendered
body.error_rendered
field on Segment.Release Notes