Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] GITPOD_RESOLVED_EXTENSIONS is not valid json #5104

Closed
akosyakov opened this issue Aug 7, 2021 · 6 comments · Fixed by #5108
Closed

[server] GITPOD_RESOLVED_EXTENSIONS is not valid json #5104

akosyakov opened this issue Aug 7, 2021 · 6 comments · Fixed by #5108

Comments

@akosyakov
Copy link
Member

akosyakov commented Aug 7, 2021

Bug description

Actually it seems to be another bug, for some reasons GITPOD_RESOLVED_EXTENSIONS is not complete in my repo, so Code Server cannot install extensions:
Screenshot 2021-08-07 at 12 00 06

@csweichel Could it be that there is some length constraint on value of set env variable?

Steps to reproduce

Not sure, maybe installing https://open-vsx.org/extension/akosyakov/gitpod-monitor

Expected behavior

No response

Example repository

No response

Anything else?

No response

@akosyakov akosyakov added type: bug Something isn't working component: server labels Aug 7, 2021
@akosyakov akosyakov changed the title [server] GITPOD_RESOLVED_EXTENSIONS is not properly computed [server] GITPOD_RESOLVED_EXTENSIONS is not valid json Aug 7, 2021
@akosyakov
Copy link
Member Author

Jaeger tracing shows that the server sends a valid JSON to ws-manager.

@akosyakov akosyakov added the priority: highest (user impact) Directly user impacting label Aug 8, 2021
@akosyakov
Copy link
Member Author

akosyakov commented Aug 8, 2021

I think many users are affected, for some reasons everything after last = is stripped from env var's value. I see the same in GOFLAGS in this repo:

ENV GOFLAGS="-mod=readonly"

@akosyakov
Copy link
Member Author

I see that environ of supervisor is good, but child processes are not.

@akosyakov
Copy link
Member Author

It's a regression since #4923 We use stings.Split unconstrained.

/schedule

@roboquat
Copy link
Contributor

roboquat commented Aug 8, 2021

@akosyakov: We have more than 21 cards scheduled. Above 15 only scheduler can perform this action. Those are:

  • csweichel
  • JanKoehnlein

In response to this:

It's a regression since #4923 We use stings.Split unconstrained.

/schedule

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csweichel
Copy link
Contributor

/schedule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants