Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non streamed responses #3

Merged
merged 5 commits into from
Oct 7, 2024

Conversation

sgoedecke
Copy link
Collaborator

Models like o1 require non-streamed responses. To make that work, I've introduced a common interface that lets us treat these like normal streamed responses (with one large chunk). I've also had to tweak the consuming code to accept data either from .Delta or .Message, since non-streamed responses will use .Message.

While I'm here, I've added some more explicit instructions about developing/releasing this locally.

@sgoedecke sgoedecke requested review from brannon and Copilot October 7, 2024 00:25
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎁 Share your feedback on Copilot Code Reviews and get GitHub Shop credit!

  • Complete this short 3 minute survey and tell us how we can improve Copilot Code Reviews for you and your team.
  • Leave feedback on Copilot's comments using the 👍 and 👎 buttons on each review comment, and you could be one of 3 Hubbers to win a $50 GitHub Shop credit.

README.md Show resolved Hide resolved
internal/sse/mockeventreader.go Show resolved Hide resolved
internal/azure_models/client.go Outdated Show resolved Hide resolved
internal/azure_models/client.go Show resolved Hide resolved
internal/azure_models/client.go Show resolved Hide resolved
Copy link

@itsbagpack itsbagpack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the logic and structure makes sense! Left a couple of questions more around my lack of knowledge around this neck of the woods 😆

cmd/run/run.go Show resolved Hide resolved
internal/sse/eventreader.go Outdated Show resolved Hide resolved
@sgoedecke sgoedecke merged commit 818e4a9 into main Oct 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants