Pin fetch-metadata by SHA
#946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
commented
May 12, 2023
| @@ -9,7 +9,7 @@ jobs: | |||
| if: ${{ github.event.pull_request.user.login == 'dependabot[bot]' }} | |||
| steps: | |||
| - name: Fetch metadata | |||
| uses: dependabot/[email protected] | |||
There was a problem hiding this comment.
The other option since we control this action is to pin @v1... but since this ships to GHES I'm not sure if it might be better to keep it fully deterministic in the off-chance that we accidentally ship a breaking change to fetch-metadata w/o realizing it we don't hose all those GHES users... 🤷♂️
jurre
approved these changes
May 12, 2023
This is mostly cosmetic, since we control the action so aren't worried about something nefarious happening. But it's also good practice, and makes our security bot reviewer happy.
jeffwidman
force-pushed
the
pin-fetch-metadata-by-sha
branch
from
8d42b53 to
b387f7b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly cosmetic, since we control the action so aren't worried about something nefarious happening. But it's also good practice, and makes our security bot reviewer happy.