Pin docker images by tag in addition to sha #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
changed the title
mctofu
force-pushed
the
deivid-rodriguez/also-pin-by-tag
branch
from
d16722b to
cbf4f21
Compare
There's an open PR for Dependabot to fix updating images pinned only by SHA, but it's not yet released. As a workaround, we can also pin by tag which is handled more efficiently. It also makes it easier to determine which version of the updater & proxy are being used. Co-authored-by: David Rodríguez <[email protected]>
mctofu
changed the title
mctofu
force-pushed
the
deivid-rodriguez/also-pin-by-tag
branch
from
cbf4f21 to
f5456a9
Compare
jakecoffman
approved these changes
Jan 3, 2023
landongrindheim
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add version tag to proxy & updater docker tags in addition to the SHA.
There's an open PR for Dependabot to fix updating images pinned only by SHA when there's a large number of images available, but it's not yet released.
As a workaround, we can also pin by tag which is handled more efficiently.
It also makes it easier to determine which version of the updater & proxy are being used.