Add MethodAccessSystemGetProperty predicate #4898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smowton
reviewed
Jan 4, 2021
| @@ -16,5 +16,6 @@ class PrintAstConfigurationOverride extends PrintAstConfiguration { | |||
| /** | |||
| * TWEAK THIS PREDICATE AS NEEDED. | |||
| */ | |||
| override predicate shouldPrint(Element e, Location l) { super.shouldPrint(e, l) } | |||
| override predicate shouldPrint(Element e, Location l) { super.shouldPrint(e, l) and | |||
| not l.getFile().getBaseName().matches("SystemGetPropertyCall.java") } | |||
There was a problem hiding this comment.
Nope, this is intentional. Do you want me to just update the test result?
There was a problem hiding this comment.
Yes, please update the test result instead.
There was a problem hiding this comment.
This should be resolved now.
java/ql/src/semmle/code/java/JDK.qll
Outdated
| MethodAccessSystemGetProperty() { getMethod() instanceof MethodSystemGetProperty } | ||
|
|
||
| /** | ||
| * Holds true if this is a compile-time constant call for the specified `propertyName`. |
There was a problem hiding this comment.
Suggested change
| * Holds true if this is a compile-time constant call for the specified `propertyName`. | |
| * Holds true if this call gets a compile-time constant property `propertyName`. |
There was a problem hiding this comment.
I believe this is resolved.
aschackmull
reviewed
Jan 4, 2021
aschackmull
reviewed
Jan 4, 2021
aschackmull
reviewed
Jan 4, 2021
Co-authored-by: Anders Schack-Mulligen <[email protected]>
JLLeitschuh
force-pushed
the
feat/JLL/system_get_property
branch
from
99c0ef1 to
ba4a562
Compare
|
This should be ready for another review pass. 😄 Thanks for the quick turnarround on feedback! |
aschackmull
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple predicate looks for calls to
System.getPropertywith a compile time constant.This pattern is pretty common. As an example: https://lgtm.com/query/1737527738205752665/
This PR is a dependency for both #4388 & #4473