Telemetry: Handle failures determining disk usage #2112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeisenberg
approved these changes
Feb 2, 2024
Comment on lines
+243
to
+244
| statusReport.runner_available_disk_space_bytes = diskInfo.numAvailableBytes; | ||
| statusReport.runner_total_disk_space_bytes = diskInfo.numTotalBytes; |
There was a problem hiding this comment.
Do we want to capture the reason for the df failure and send it as part of the status report?
There was a problem hiding this comment.
The message wouldn't make it into kusto, but at least it would be available in splunk.
There was a problem hiding this comment.
We could probably add an internal error diagnostic for this. Let's address as potential follow up, as you suggest.
henrymercer
deleted the
henrymercer/status-report-handle-disk-failures
branch
This was referenced Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've noticed some situations where
dffails due to the tracer not initializing correctly, and therefore we are unable to determine available disk space. Let's instead fail gracefully when we can't determine available disk space.Merge / deployment checklist