Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: disable dependency installation on GHES #2106

Merged
merged 4 commits into from
Feb 1, 2024

Conversation

RasmusWL
Copy link
Member

After succesfully rolling out this change to all customers on github.com (see https://github.blog/changelog/2024-01-23-codeql-2-16-python-dependency-installation-disabled-new-queries-and-bug-fixes/), this PR will ensure it is also disabled for new GHES releases.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

As announced in https://github.blog/changelog/2024-01-23-codeql-2-16-python-dependency-installation-disabled-new-queries-and-bug-fixes/ we have turned on this feature flag for github.com already.

This change ensures that users on GHES also has this feature enabled by
default.
@RasmusWL RasmusWL requested a review from a team as a code owner January 30, 2024 16:20
henrymercer
henrymercer previously approved these changes Jan 30, 2024
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a small suggestion for the changelog note for consistency.

CHANGELOG.md Outdated Show resolved Hide resolved
@RasmusWL
Copy link
Member Author

RasmusWL commented Feb 1, 2024

Looks good, just a small suggestion for the changelog note for consistency.

thanks ❤️

@RasmusWL RasmusWL merged commit 483bef1 into main Feb 1, 2024
317 checks passed
@RasmusWL RasmusWL deleted the rasmuswl/default-no-dep-inst branch February 1, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants