Fix table cannot be recoginsed without empty line #154

jinhucheung · 2019-05-06T09:09:08Z

kivikakk

This is great -- thank you so much. I'm going to run some fuzzing on this to make sure it holds up OK, but it looks good to me. 👍

kivikakk · 2019-05-07T02:11:51Z

test/extensions.txt

@@ -150,7 +150,7 @@ Hello!

 | _abc_ | セン |
 | ----- | ---- |
-| this row has a space at the end | | 
+| this row has a space at the end | |


This is "whitespace trimming" on vscode ❤️

jinhucheung · 2019-05-07T03:41:49Z

extensions/table.c

+
+  paragraph = cmark_node_new_with_mem(CMARK_NODE_PARAGRAPH, parser->mem);
+
+  paragraph_content = unescape_pipes(parser->mem, parent_string, paragraph_offset);


removed redundant type conversions 7f69c4e

`cmark_node_set_string_content` allocates and copies the data in `paragraph_content` so it is not needed afterwards. ``` ================================================================= ==14==ERROR: LeakSanitizer: detected memory leaks Direct leak of 24 byte(s) in 1 object(s) allocated from: 0 0x4dd330 in calloc /src/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:97 1 0x59e243 in xcalloc /src/octofuzz/src/cmark.c:18:15 2 0x58fd75 in unescape_pipes /src/octofuzz/extensions/table.c:95:39 3 0x58fd75 in try_inserting_table_header_paragraph /src/octofuzz/extensions/table.c:187 4 0x58fd75 in try_opening_table_header /src/octofuzz/extensions/table.c:254 5 0x58fd75 in try_opening_table_block /src/octofuzz/extensions/table.c:370 6 0x5b22d5 in open_new_blocks /src/octofuzz/src/blocks.c:1275:27 7 0x5b22d5 in S_process_line /src/octofuzz/src/blocks.c:1465 8 0x5aa7f0 in cmark_parser_finish /src/octofuzz/src/blocks.c:1492:5 9 0x58f2fc in LLVMFuzzerTestOneInput /src/octofuzz/test/cmark-fuzz.c:46:23 Indirect leak of 8 byte(s) in 1 object(s) allocated from: 0 0x4dd580 in realloc /src/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:107 1 0x59e2d3 in xrealloc /src/octofuzz/src/cmark.c:27:19 2 0x640364 in cmark_strbuf_grow /src/octofuzz/src/buffer.c:57:31 3 0x640364 in cmark_strbuf_init /src/octofuzz/src/buffer.c:31 4 0x58fd8b in unescape_pipes /src/octofuzz/extensions/table.c:98:3 5 0x58fd8b in try_inserting_table_header_paragraph /src/octofuzz/extensions/table.c:187 6 0x58fd8b in try_opening_table_header /src/octofuzz/extensions/table.c:254 7 0x58fd8b in try_opening_table_block /src/octofuzz/extensions/table.c:370 8 0x5b22d5 in open_new_blocks /src/octofuzz/src/blocks.c:1275:27 9 0x5b22d5 in S_process_line /src/octofuzz/src/blocks.c:1465 10 0x5aa7f0 in cmark_parser_finish /src/octofuzz/src/blocks.c:1492:5 11 0x58f2fc in LLVMFuzzerTestOneInput /src/octofuzz/test/cmark-fuzz.c:46:23 SUMMARY: AddressSanitizer: 32 byte(s) leaked in 2 allocation(s). ```

kivikakk · 2019-05-08T01:12:59Z

I've pushed 15e924d from @philipturnbull, who found a memory leak while fuzzing this branch.

kivikakk · 2019-05-08T01:22:06Z

@jinhucheung Thank you for your PR!

See github/cmark-gfm#154. This was my doing 🤦‍♀️

* fix(table): recoginse-without-empty-line (#141) * fix(table): fix bufsize_t not convert to uint16_t * fix(table): fix uint16_6 not convert to int * fix(table): fix uint16_6 not convert to int * fix(table): clear unused type conversion * restore whitespace * Always free `paragraph_content` `cmark_node_set_string_content` allocates and copies the data in `paragraph_content` so it is not needed afterwards. ``` ================================================================= ==14==ERROR: LeakSanitizer: detected memory leaks Direct leak of 24 byte(s) in 1 object(s) allocated from: 0 0x4dd330 in calloc /src/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:97 1 0x59e243 in xcalloc /src/octofuzz/src/cmark.c:18:15 2 0x58fd75 in unescape_pipes /src/octofuzz/extensions/table.c:95:39 3 0x58fd75 in try_inserting_table_header_paragraph /src/octofuzz/extensions/table.c:187 4 0x58fd75 in try_opening_table_header /src/octofuzz/extensions/table.c:254 5 0x58fd75 in try_opening_table_block /src/octofuzz/extensions/table.c:370 6 0x5b22d5 in open_new_blocks /src/octofuzz/src/blocks.c:1275:27 7 0x5b22d5 in S_process_line /src/octofuzz/src/blocks.c:1465 8 0x5aa7f0 in cmark_parser_finish /src/octofuzz/src/blocks.c:1492:5 9 0x58f2fc in LLVMFuzzerTestOneInput /src/octofuzz/test/cmark-fuzz.c:46:23 Indirect leak of 8 byte(s) in 1 object(s) allocated from: 0 0x4dd580 in realloc /src/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:107 1 0x59e2d3 in xrealloc /src/octofuzz/src/cmark.c:27:19 2 0x640364 in cmark_strbuf_grow /src/octofuzz/src/buffer.c:57:31 3 0x640364 in cmark_strbuf_init /src/octofuzz/src/buffer.c:31 4 0x58fd8b in unescape_pipes /src/octofuzz/extensions/table.c:98:3 5 0x58fd8b in try_inserting_table_header_paragraph /src/octofuzz/extensions/table.c:187 6 0x58fd8b in try_opening_table_header /src/octofuzz/extensions/table.c:254 7 0x58fd8b in try_opening_table_block /src/octofuzz/extensions/table.c:370 8 0x5b22d5 in open_new_blocks /src/octofuzz/src/blocks.c:1275:27 9 0x5b22d5 in S_process_line /src/octofuzz/src/blocks.c:1465 10 0x5aa7f0 in cmark_parser_finish /src/octofuzz/src/blocks.c:1492:5 11 0x58f2fc in LLVMFuzzerTestOneInput /src/octofuzz/test/cmark-fuzz.c:46:23 SUMMARY: AddressSanitizer: 32 byte(s) leaked in 2 allocation(s). ```

fix(table): recoginse-without-empty-line (#141)

34e0c17

jinhucheung changed the title ~~Fix table can not be recoginsed without empty line~~ Fix table cannot be recoginsed without empty line May 6, 2019

jinhucheung added 3 commits May 6, 2019 17:17

fix(table): fix bufsize_t not convert to uint16_t

9f64028

fix(table): fix uint16_6 not convert to int

c646b3b

fix(table): fix uint16_6 not convert to int

c9f57c3

kivikakk approved these changes May 7, 2019

View reviewed changes

fix(table): clear unused type conversion

7f69c4e

jinhucheung commented May 7, 2019

View reviewed changes

kivikakk and others added 2 commits May 8, 2019 11:09

restore whitespace

76c46ef

kivikakk merged commit ef13dc5 into github:master May 8, 2019

jinhucheung deleted the fix-table-not-recognised-without-empty-line branch May 8, 2019 02:11

kivikakk added a commit to kivikakk/comrak that referenced this pull request Apr 9, 2021

test: add failing test for table after no newline

165dac7

See github/cmark-gfm#154. This was my doing 🤦‍♀️

kivikakk mentioned this pull request Apr 9, 2021

recognise table without empty line kivikakk/comrak#183

Merged

This was referenced Oct 5, 2021

GFM tables without leading empty lines inside list items are interpreted incorrectly as plain text pulldown-cmark/pulldown-cmark#540

Closed

GFM tables right after paragraphs are not recognized prettier/prettier#11633

Open

bluishoul mentioned this pull request Oct 9, 2021

Table 紧跟的上一行不是空行时，SpinVditorSVDOM 会将整个表格过滤掉 88250/lute#158

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix table cannot be recoginsed without empty line #154

Fix table cannot be recoginsed without empty line #154

jinhucheung commented May 6, 2019

kivikakk left a comment

kivikakk May 7, 2019

jinhucheung May 7, 2019

jinhucheung May 7, 2019

kivikakk commented May 8, 2019

kivikakk commented May 8, 2019

	\| this row has a space at the end \| \|
	\| this row has a space at the end \| \|


		paragraph = cmark_node_new_with_mem(CMARK_NODE_PARAGRAPH, parser->mem);

		paragraph_content = unescape_pipes(parser->mem, parent_string, paragraph_offset);

Fix table cannot be recoginsed without empty line #154

Fix table cannot be recoginsed without empty line #154

Conversation

jinhucheung commented May 6, 2019

kivikakk left a comment

Choose a reason for hiding this comment

kivikakk May 7, 2019

Choose a reason for hiding this comment

jinhucheung May 7, 2019

Choose a reason for hiding this comment

jinhucheung May 7, 2019

Choose a reason for hiding this comment

kivikakk commented May 8, 2019

kivikakk commented May 8, 2019