allow disabling checkout via admin #9870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: apply the cap after normalising the distribution * fix: adds flag to estimate_clr so that we can skip saving the results * fix: expose id and title to make it easier to compare results * fix: apply Adityas comments * add logging * add more logs * add logging * fix: adds id to totals * fix: clean up logs * fix: ensures we dont spread the remainder if we havent reached the saturation point * fix: debug output Co-authored-by: Aditya Anand M C <[email protected]>
thelostone-mc
requested review from
chibie,
frankchen07,
gdixon,
nutrina and
PixelantDesign
as code owners
|
The changes look good, but I was wondering if it would make sense to also display a message to the users, to let them know what is happening. |
gdixon
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows admin to toggle checkout options using Static JSON store as opposed to relying on a deploy every single time. The Static JSON has already been created in admin
This takes away the need for engineering to be involved and have operations toggle switches
Why are we doing this
==================
Message from zksync team :
==================
Tomorrow (most likely in 8-12 hours) we need to update the server. Unfortunately I can not yet tell the exact time when we will be able to start, it may cause the downtime for a few minutes. Most likely users won't feel any effect, but I think you should know in case there will be support requests on that matter. We are sorry for the short notice 😦
Thank you for understanding!