Fix fragility in Cypress tests #9867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyschuurmans
requested review from
chibie,
frankchen07,
gdixon,
nutrina,
PixelantDesign and
thelostone-mc
as code owners
jeremyschuurmans
changed the title
jeremyschuurmans
changed the title
gdixon
approved these changes
Dec 9, 2021
chibie
approved these changes
Dec 9, 2021
jeremyschuurmans
force-pushed
the
jeremy/fix-broken-cypress-tests
branch
from
a67f277 to
49f83be
Compare
nutrina
pushed a commit
that referenced
this pull request
Dec 10, 2021
* refactor assertions to make the tests less fragile * refactor sort request specs to remove fragility * fix: eslint issues Co-authored-by: Graham Dixon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors fragile Cypress tests to avoid unintentional test failures in future
Refers/Fixes
Testing