Action URLS Cleanup (and other goodies) #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Apr 25, 2018
| # Interests | ||
| path('actions/bounty/<int:bounty_id>/interest/new/', dashboard.views.new_interest, name='express-interest'), | ||
| path('actions/bounty/<int:bounty_id>/interest/remove/', dashboard.views.remove_interest, name='remove-interest'), | ||
| path('actions/bounty/<int:bounty_id>/interest/<int:profile_id>/uninterested/', dashboard.views.uninterested, name='uninterested'), |
There was a problem hiding this comment.
E501 line too long (134 > 120 characters)
app/dashboard/views.py
Outdated
| @@ -493,11 +478,39 @@ def new_bounty(request): | |||
| return TemplateResponse(request, 'submit_bounty.html', params) | |||
|
|
|||
|
|
|||
| def fulfill_bounty(request): | |||
|
|
|||
| def accept_bounty(request, pk): | |||
Codecov Report
@@ Coverage Diff @@
## master #983 +/- ##
==========================================
- Coverage 32.85% 32.83% -0.02%
==========================================
Files 100 100
Lines 6614 6621 +7
Branches 809 808 -1
==========================================
+ Hits 2173 2174 +1
- Misses 4332 4338 +6
Partials 109 109
Continue to review full report at Codecov.
|
stickler-ci
reviewed
Apr 25, 2018
stickler-ci
reviewed
Apr 26, 2018
stickler-ci
reviewed
Apr 26, 2018
stickler-ci
reviewed
Apr 26, 2018
app/dashboard/views.py
Outdated
| issue_url = request.GET.get('source') | ||
| def increase_bounty(request, pk): | ||
| """Increase a bounty as the funder. | ||
|
|
There was a problem hiding this comment.
W293 blank line contains whitespace
app/dashboard/views.py
Outdated
|
|
||
| Returns: | ||
| TemplateResponse: The increase bounty view. | ||
|
|
There was a problem hiding this comment.
W293 blank line contains whitespace
stickler-ci
reviewed
Apr 26, 2018
app/dashboard/views.py
Outdated
| def fulfill_bounty(request): | ||
| """Fulfill a bounty.""" | ||
|
|
||
| def accept_bounty(request, pk): |
stickler-ci
reviewed
Apr 26, 2018
stickler-ci
reviewed
Apr 26, 2018
stickler-ci
reviewed
Apr 26, 2018
stickler-ci
reviewed
Apr 26, 2018
mbeacom
reviewed
Apr 26, 2018
There was a problem hiding this comment.
Overall, lgtm.
Made a few changes:
- docstrings to reflected the updates and conform to pep-257/258.
- url entries being moved around to use the current django methods:
re_pathversusurl - bare
excepttoexcept Bounty.DoesNotExistto passflake8E722
We might want to hold off on merging this until we have pytest/travis in a passing state, though!
stickler-ci
reviewed
Apr 26, 2018
stickler-ci
reviewed
Apr 26, 2018
|
buidl passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR
Checklist
Affected core subsystem(s)
ui, bounty
Testing
tested it end to end
Refers/Fixes
#533