GITC-478: Caching github user object. #9804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nutrina
requested review from
chibie,
frankchen07,
gdixon,
PixelantDesign and
thelostone-mc
as code owners
ksolo
reviewed
Dec 2, 2021
nutrina
force-pushed
the
GITC-478-github-rate-limit
branch
from
91e9485 to
aa5305e
Compare
|
@ksolo Have added test cases |
nutrina
force-pushed
the
GITC-478-github-rate-limit
branch
from
aa5305e to
fea7217
Compare
nutrina
force-pushed
the
GITC-478-github-rate-limit
branch
from
fea7217 to
836170a
Compare
Have created model to store the serialized github entities. Have also reworked code, mainly in the `git/utils.py` file to make use of this cache.
nutrina
force-pushed
the
GITC-478-github-rate-limit
branch
from
836170a to
ba6a0c3
Compare
ksolo
approved these changes
Dec 6, 2021
|
@thelostone-mc I have rebased this to stable |
thelostone-mc
approved these changes
Dec 7, 2021
nutrina
added a commit
that referenced
this pull request
Dec 10, 2021
* GITC-478: Caching github user object. Have created model to store the serialized github entities. Have also reworked code, mainly in the `git/utils.py` file to make use of this cache. * GITC-478: remove logs for sensitive data * GITC-478: Adding tests
alicii93
reviewed
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have created model to store the serialized github entities. Have also reworked code, mainly in the
git/utils.pyfile to make use of this cache.Description
This fixes the caching and conditional requests for the user object from Github API.
For now this only handles the user obejct requests, but this fix can be extended for repo and issue objects as well.
Refers/Fixes
GITC-478
This should fix the high amount of rate limit errors in sentry.
Testing
This would normally be triggered by going to the profile or dashboard pages for a user.