GITC-616: fetch gas price from polygon gas tracker #9733
Conversation
chibie
requested review from
frankchen07,
gdixon,
nutrina,
PixelantDesign and
thelostone-mc
as code owners
| @@ -381,6 +382,14 @@ Vue.component('grantsCartEthereumPolygon', { | |||
|
|
|||
| let gasLimit = 0; | |||
|
|
|||
| // fetch gas prices from polygon gas tracker | |||
| if (!this.polygon.gasPrices) { | |||
| const priceUrl = 'https://api.polygonscan.com/api?module=gastracker&action=gasoracle&apikey=I28K1DVQAWAISBSI146I71YQDBK6N1C9GJ'; | |||
There was a problem hiding this comment.
We might want to switch this out for a paid account or move this to the backend and set up a cron to store and update the safeGasPrice periodically.
This is going to get hammered if we call it every time a user hits the checkout.
There was a problem hiding this comment.
I'd say set a high default price and wrap this in a try catch for now
There was a problem hiding this comment.
Shouldn't we load the api key from the settings?
There was a problem hiding this comment.
Oh that is a nice catch ! @chibie i agree with nutrina here
There was a problem hiding this comment.
Yeah we should really be protecting that key - I would recommend moving this to the backend and returning the safeGasPrice as part of the context.
Description
This pr fetches the gas price from polygon gas tracker as opposed to hardcoding it.
Refers/Fixes
Testing
tested locally