GITC-502: infinite-scroll-stops-working-after-applying-filter #9720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyschuurmans
requested review from
chibie,
frankchen07,
gdixon,
PixelantDesign and
thelostone-mc
as code owners
jeremyschuurmans
changed the title
gdixon
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where infinite scroll would break after applying filters to the results in the grants explorer.
The issue was that before the next page of results would be fetched from the API, the app would check to make sure that it had not been fetched already. Before the initial
fetch,!pageIsFetchedreturns true, and so thefetchwill proceed. After the initialfetch,!pageIsFetchedreturnsfalse, preventing subsequent pages from being fetched.Removing the
pageIsFetchedcheck resolves this issue.Screen.Recording.2021-11-23.at.10.25.49.AM.mov
Refers/Fixes
Testing