Fixing bug in grants explorer scrolling. #9714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nutrina
requested review from
chibie,
frankchen07,
gdixon,
PixelantDesign and
thelostone-mc
as code owners
|
@thelostone-mc This is the fix for the bug we discussed. |
|
Hey @nutrina, can you reset and cherry-pick your commit back on? |
|
@gdixon Yes, I am doing that |
nutrina
force-pushed
the
grants_explorer_scroll_bug
branch
from
c42c051 to
027df58
Compare
thelostone-mc
approved these changes
Nov 22, 2021
OoLionardo
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In grants explorer not all pages are loaded when scrolling.
This change fixes the issue by removing an erroneous setting of the flag
vm.grantsHasNext = falseRefers/Fixes
Testing
Before fix: in the grants explorer only a limited subset of the grants are shown in total (normally the first 2 pages, 12 items). Scrolling down doesn't load all items.
After fix: all the grants are loaded as the user scroll down.