Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: revamp grant creation flow #9706

Merged
merged 9 commits into from
Nov 29, 2021
Merged

feat: revamp grant creation flow #9706

merged 9 commits into from
Nov 29, 2021

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Nov 19, 2021 •
edited
Loading

Description
  • Revamp Grant Creation
  • Hide Grant Type and default it to gr12

Note: Ensure gr12 is created on backend

Testing

Untitled

chibie
chibie reviewed Nov 23, 2021
View reviewed changes
Copy link
Contributor

@chibie chibie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have screenshots (desktop+responsive) or a vid?

@gdixon
Copy link
Contributor

gdixon commented Nov 26, 2021

@ksolo - could you have a look at the cyprus tests on this one please?

gdixon
gdixon approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@gdixon gdixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

cypress/integration/grants/test_grant_creation.js Outdated Show resolved Hide resolved
@thelostone-mc thelostone-mc merged commit 9ef19c7 into gitcoinco:master Nov 29, 2021
@frankchen07
Copy link
Contributor

frankchen07 commented Nov 30, 2021 •
edited by gdixon
Loading

  • edit grant not showing on grant details page after creating grant (check GPG channel)
  • remove link to slack in the "grant guide" -> "start a grant" tab
  • can we alpha sort tags on the grant creation form?
  • link tags learn more to happy fox page (https://gitcoin.happyfox.com/staff/kb/articles/134-learn-more-about-matching-rounds)
  • Region field description should be, “Where is your team based?” (Rather than “where is your team based in?”)

@gdixon gdixon mentioned this pull request Dec 1, 2021
Merged
3 tasks
thelostone-mc pushed a commit that referenced this pull request Dec 1, 2021
@gdixon
fix: addresses Franks feedback on #9706 (#9784)
bab6324 
* fix: swap slack for discord

* fix: ensure tags are sorted correctly

* fix: grammar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chibie chibie chibie left review comments

@gdixon gdixon gdixon approved these changes

@frankchen07 frankchen07 Awaiting requested review from frankchen07

@PixelantDesign PixelantDesign Awaiting requested review from PixelantDesign

@nutrina nutrina Awaiting requested review from nutrina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thelostone-mc @gdixon @frankchen07 @chibie