GITC-599: remove duplicates in token selection input (cart + tips) #9692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chibie
requested review from
frankchen07,
gdixon,
PixelantDesign and
thelostone-mc
as code owners
gdixon
reviewed
Nov 16, 2021
|
|
||
| return vm.filterByChainId.filter( | ||
| obj => !uniq[obj['name']] && (uniq[obj['name']] = true) | ||
| ); |
There was a problem hiding this comment.
This is going to leave behind tokens which are not configured for polygon, will that present an issue? Instead of removing duplicates, could we filter by chainId AND networkId?
|
what do we want to do here guys ? |
i'd say we merge this the alternative ux flow where a user selects the checkout option before selecting a token will also mean checkout recommendation may not be possible cause the current flow is,
|
gdixon
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refers/Fixes
Testing
tested locally