Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GITC-500: Adds ability to recalculate inactive rounds #9678

Closed
wants to merge 2 commits into from

Conversation

gdixon
Copy link
Contributor

@gdixon gdixon commented Nov 11, 2021

Description

This PR adds the ability to trigger a recalc on inactive rounds in the GrantCLR admin page

Refers/Fixes

Fixes: GITC-500

Testing

Tested locally

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: once an admin recalculates the 2 inactive rounds -> does the CLR Calculations table have the latest flag for the latest calculations / does it get reset ?

@gdixon
Copy link
Contributor Author

gdixon commented Nov 11, 2021

Question: once an admin recalculates the 2 inactive rounds -> does the CLR Calculations table have the latest flag for the latest calculations / does it get reset ?

Nice catch - it would be reset - once we've merged GITC-475, we should move the change that I made in 6af7f09 to the active field (it doesn't want to be on latest, I've just left it there as a reminder!), which should cover us for these inactive round recalcs 👍

Comment on lines +495 to +498
self.message_user(request, f"submitted recaclulation of GrantCLR:{ selected_clr } to queue")
else:
recalc_clr.delay(False)
self.message_user(request, "submitted recaclulation to queue")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recaclulation recalculation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants