Randomized but meaningful collections displayed on collections tab #9672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hile giving collections with meaningful metadata more of a chance of being shown closer to the top Refs: gitcoinco#9614
tim-schultz
requested review from
chibie,
frankchen07,
gdixon,
PixelantDesign and
thelostone-mc
as code owners
|
codewise LGTM! Could you throw in a video as well ? |
chibie
approved these changes
Nov 10, 2021
|
Thanks @chibie and @thelostone-mc! Here's a video of it shuffling the collections after the scheduled command being run. Just let me know if I can provide any other information! grant_collection_shuffle_720.mov |
gdixon
approved these changes
Nov 15, 2021
There was a problem hiding this comment.
This looks awesome @schultztimothy and gives us a perfect starting point! Thank you!
@frankchen07 - it would be great if we could get some more direction on exactly how we want to seed the initial rank for the collections, atm Tim is using the age of the collection + some trust scoring (does the grant have a github url, have they passed twitter verification?)
I think this is good for now, and we should add a new ticket in the backlog to explore our options here 👍
OoLionardo
approved these changes
Feb 14, 2022
OoLionardo
approved these changes
Feb 14, 2022
OoLionardo
approved these changes
Feb 14, 2022
OoLionardo
approved these changes
Feb 14, 2022
OoLionardo
approved these changes
Feb 14, 2022
OoLionardo
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort collections based on updated shuffle_rank that randomizes sort while giving collections with meaningful metadata more of a chance of being shown closer to the top
Refs: #9614
Description
These changes sort collections randomly by giving each collection a shuffle_rank. This shuffle_rank is then increased if the collection and related grants contain meaningful data. When the shuffle ranks is increased it gives the collection a higher chance of appearing close to the top of the page.
Refers/Fixes
Refs: #9614
Testing
Unit tests were added to functions that collections