Testing workshop #9668
Merged
Testing workshop #9668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksolo
requested review from
chibie,
frankchen07,
gdixon,
PixelantDesign and
thelostone-mc
as code owners
ksolo
force-pushed
the
testing-workshop/dashboard-models
branch
from
af39944 to
a07c73b
Compare
chibie
approved these changes
Nov 18, 2021
added 7 commits
November 18, 2021 09:38
ksolo
force-pushed
the
testing-workshop/dashboard-models
branch
from
a07c73b to
ab1c515
Compare
gdixon
reviewed
Nov 19, 2021
| from grants.models.cart_activity import CartActivity | ||
|
|
||
| from .grant_factory import GrantFactory | ||
|
|
||
|
|
||
| @pytest.mark.django_db | ||
| class CartActivityFactory(factory.django.DjangoModelFactory): | ||
| """Create mock CartActivity for testing.""" |
There was a problem hiding this comment.
How come were removing all of these descriptions?
There was a problem hiding this comment.
I removed them because they were technically not correct, these are factories not mocks. I also didn't think they added context. I am happy to put them back in though with the correction that they are factories that return instances of the Django Model.
There was a problem hiding this comment.
Thats cool with me, I think they're well enough named that we don't need the descriptions!
Co-authored-by: Graham Dixon <[email protected]>
gdixon
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to workshop:
tests/factoriesinstead oftests/models/factoriesto make them easier to findWorkshop - added bountry fulfillment test.